Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Fix length properties on array methods #1983

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - Fix length properties on array methods #1983

wants to merge 1 commit into from

Conversation

lupd
Copy link
Contributor

@lupd lupd commented Mar 28, 2022

This Pull Request fixes length properties on multiple array prototype methods that were including rest parameters in the count. More tests should pass.

It changes the following:

  • Length properties on some array prototype methods

@codecov
Copy link

codecov bot commented Mar 28, 2022 •
edited
Loading

Codecov Report

Merging #1983 (c90e9e2) into main (5d2420e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1983   +/-   ##
=======================================
  Coverage   45.93%   45.93%           
=======================================
  Files         206      206           
  Lines       17138    17138           
=======================================
  Hits         7873     7873           
  Misses       9265     9265
Impacted Files Coverage Δ
boa_engine/src/builtins/array/mod.rs 75.78% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d2420e...c90e9e2. Read the comment docs.

@jedel1043
Copy link
Member

VM implementation

Test result main count PR count difference
Total 88,428 88,428 0
Passed 43,991 44,001 +10
Ignored 21,495 21,495 0
Failed 22,942 22,932 -10
Panics 0 0 0
Conformance 49.75% 49.76% +0.01%
Fixed tests (10): 
test/built-ins/Array/prototype/reduce/length.js [strict mode] (previously Failed)
test/built-ins/Array/prototype/reduce/length.js (previously Failed)
test/built-ins/Array/prototype/copyWithin/length.js [strict mode] (previously Failed)
test/built-ins/Array/prototype/copyWithin/length.js (previously Failed)
test/built-ins/Array/prototype/reduceRight/length.js [strict mode] (previously Failed)
test/built-ins/Array/prototype/reduceRight/length.js (previously Failed)
test/built-ins/Array/prototype/splice/length.js [strict mode] (previously Failed)
test/built-ins/Array/prototype/splice/length.js (previously Failed)
test/built-ins/Array/prototype/some/length.js [strict mode] (previously Failed)
test/built-ins/Array/prototype/some/length.js (previously Failed)

raskad
raskad approved these changes Mar 28, 2022
View reviewed changes
Copy link
Member

@raskad raskad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find!

@raskad raskad added bug Something isn't working builtins PRs and Issues related to builtins/intrinsics labels Mar 28, 2022
@raskad raskad added this to the v0.15.0 milestone Mar 28, 2022
jedel1043
jedel1043 approved these changes Mar 28, 2022
View reviewed changes
Copy link
Member

@jedel1043 jedel1043 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job :)

@raskad
Copy link
Member

raskad commented Mar 29, 2022

bors r+

bors bot pushed a commit that referenced this pull request Mar 29, 2022
@lupd
Fix length properties on array methods (#1983)
5498a0e 
This Pull Request fixes length properties on multiple array prototype methods that were including rest parameters in the count. More tests should pass.

It changes the following:

- Length properties on some array prototype methods
@bors
Copy link

bors bot commented Mar 29, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Fix length properties on array methods [Merged by Bors] - Fix length properties on array methods Mar 29, 2022
@bors bors bot closed this Mar 29, 2022
@lupd lupd deleted the array-method-length branch March 29, 2022 02:01
Razican pushed a commit that referenced this pull request Jun 8, 2022
@lupd @Razican
Fix length properties on array methods (#1983)
5ac77ed 
This Pull Request fixes length properties on multiple array prototype methods that were including rest parameters in the count. More tests should pass.

It changes the following:

- Length properties on some array prototype methods
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jedel1043 jedel1043 jedel1043 approved these changes

@raskad raskad raskad approved these changes

Assignees
No one assigned
Labels
bug Something isn't working builtins PRs and Issues related to builtins/intrinsics
Projects
None yet
Milestone
v0.15.0
Development

Successfully merging this pull request may close these issues.
3 participants
@lupd @jedel1043 @raskad