[Merged by Bors] - Change ArrayBuffer byteLength to accessor property

[lupd]

This Pull Request fixes byteLength for ArrayBuffer. It should be an accessor property rather than a method, per the spec.

It changes the following:

• Removes byteLength method for ArrayBuffer built-in.
• Add byteLength accessor property for ArrayBuffer.
• Change byte_length function name to get_byte_length, to match other function names used for accessor properties.

[codecov]

Codecov Report

Merging #2010 (278049a) into main (ffc7a3e) will increase coverage by 0.00%.
The diff coverage is 66.66%.

@@           Coverage Diff           @@
##             main    #2010   +/-   ##
=======================================
  Coverage   45.89%   45.90%           
=======================================
  Files         206      206           
  Lines       17150    17152    +2     
=======================================
+ Hits         7871     7873    +2     
  Misses       9279     9279           

Impacted Files	Coverage Δ
boa_engine/src/builtins/array_buffer/mod.rs	9.44% <66.66%> (+1.44%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ffc7a3e...278049a. Read the comment docs.

[HalidOdat]

VM implementation

Test result	main count	PR count	difference
Total	88,650	88,650	0
Passed	44,005	44,047	+42
Ignored	21,711	21,711	0
Failed	22,934	22,892	-42
Panics	0	0	0
Conformance	49.64%	49.69%	+0.05%

Fixed tests (42):

test/built-ins/ArrayBuffer/zero-length.js [strict mode] (previously Failed)
test/built-ins/ArrayBuffer/zero-length.js (previously Failed)
test/built-ins/ArrayBuffer/toindex-length.js [strict mode] (previously Failed)
test/built-ins/ArrayBuffer/toindex-length.js (previously Failed)
test/built-ins/ArrayBuffer/length-is-absent.js [strict mode] (previously Failed)
test/built-ins/ArrayBuffer/length-is-absent.js (previously Failed)
test/built-ins/ArrayBuffer/prototype/slice/end-exceeds-length.js [strict mode] (previously Failed)
test/built-ins/ArrayBuffer/prototype/slice/end-exceeds-length.js (previously Failed)
test/built-ins/ArrayBuffer/prototype/slice/species-returns-larger-arraybuffer.js [strict mode] (previously Failed)
test/built-ins/ArrayBuffer/prototype/slice/species-returns-larger-arraybuffer.js (previously Failed)
test/built-ins/ArrayBuffer/prototype/slice/end-default-if-absent.js [strict mode] (previously Failed)
test/built-ins/ArrayBuffer/prototype/slice/end-default-if-absent.js (previously Failed)
test/built-ins/ArrayBuffer/prototype/slice/negative-start.js [strict mode] (previously Failed)
test/built-ins/ArrayBuffer/prototype/slice/negative-start.js (previously Failed)
test/built-ins/ArrayBuffer/prototype/slice/start-default-if-undefined.js [strict mode] (previously Failed)
test/built-ins/ArrayBuffer/prototype/slice/start-default-if-undefined.js (previously Failed)
test/built-ins/ArrayBuffer/prototype/slice/start-default-if-absent.js [strict mode] (previously Failed)
test/built-ins/ArrayBuffer/prototype/slice/start-default-if-absent.js (previously Failed)
test/built-ins/ArrayBuffer/prototype/slice/negative-end.js [strict mode] (previously Failed)
test/built-ins/ArrayBuffer/prototype/slice/negative-end.js (previously Failed)
test/built-ins/ArrayBuffer/prototype/slice/tointeger-conversion-end.js [strict mode] (previously Failed)
test/built-ins/ArrayBuffer/prototype/slice/tointeger-conversion-end.js (previously Failed)
test/built-ins/ArrayBuffer/prototype/slice/tointeger-conversion-start.js [strict mode] (previously Failed)
test/built-ins/ArrayBuffer/prototype/slice/tointeger-conversion-start.js (previously Failed)
test/built-ins/ArrayBuffer/prototype/slice/start-exceeds-length.js [strict mode] (previously Failed)
test/built-ins/ArrayBuffer/prototype/slice/start-exceeds-length.js (previously Failed)
test/built-ins/ArrayBuffer/prototype/slice/end-default-if-undefined.js [strict mode] (previously Failed)
test/built-ins/ArrayBuffer/prototype/slice/end-default-if-undefined.js (previously Failed)
test/built-ins/ArrayBuffer/prototype/slice/start-exceeds-end.js [strict mode] (previously Failed)
test/built-ins/ArrayBuffer/prototype/slice/start-exceeds-end.js (previously Failed)
test/built-ins/ArrayBuffer/prototype/byteLength/length.js [strict mode] (previously Failed)
test/built-ins/ArrayBuffer/prototype/byteLength/length.js (previously Failed)
test/built-ins/ArrayBuffer/prototype/byteLength/detached-buffer.js [strict mode] (previously Failed)
test/built-ins/ArrayBuffer/prototype/byteLength/detached-buffer.js (previously Failed)
test/built-ins/ArrayBuffer/prototype/byteLength/prop-desc.js [strict mode] (previously Failed)
test/built-ins/ArrayBuffer/prototype/byteLength/prop-desc.js (previously Failed)
test/built-ins/ArrayBuffer/prototype/byteLength/invoked-as-accessor.js [strict mode] (previously Failed)
test/built-ins/ArrayBuffer/prototype/byteLength/invoked-as-accessor.js (previously Failed)
test/built-ins/ArrayBuffer/prototype/byteLength/return-bytelength.js [strict mode] (previously Failed)
test/built-ins/ArrayBuffer/prototype/byteLength/return-bytelength.js (previously Failed)
test/built-ins/ArrayBuffer/prototype/byteLength/name.js [strict mode] (previously Failed)
test/built-ins/ArrayBuffer/prototype/byteLength/name.js (previously Failed)

[HalidOdat]

Looks good to me :)

[Razican]

Thanks! Looks good :)

[Razican]

bors r+

[bors]

Pull request successfully merged into main.

Build succeeded:

• Clippy
• Documentation
• Examples
• Rustfmt
• Tests on Linux
• Tests on MacOS
• Tests on Windows