Rest params for function declarations #205
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/lib/js/value.rs
Outdated
| write!(f, "function({}){}", rf.args.join(", "), rf.expr) | ||
| write!(f, "function(")?; | ||
| let last_index = rf.args.len() - 1; | ||
| for (index, arg) in rf.args.iter().enumerate() { |
There was a problem hiding this comment.
This loop can be rewritten using .iter().join().
There was a problem hiding this comment.
An attempt was made, but I'm having trouble converting rf.args into a format that supports join.
robertmaloney
force-pushed
the
spread-rest
branch
from
b5c1f17
to
8ac17fe
Compare
|
@robertmaloney this is great, do you know why the tests are failing? |
jasonwilliams
force-pushed
the
spread-rest
branch
from
8ac17fe
to
fe1f538
Compare
|
Fixed test, |
|
This has already been implemented Thanks anyway @robertmaloney ! |
|
Happy to see it taken care of, thanks for closing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #151
TODO