[Merged by Bors] - Implement Object.prototype.__defineSetter__

[wusyong]

This Pull Request fixes part of #2067.

It adds the legacy Object.prototype.__defineSetter__ function.

[jedel1043]

LGTM. Thank you for your contribution! :D

[codecov]

Codecov Report

Merging #2109 (6d6673c) into main (b7e84d4) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #2109      +/-   ##
==========================================
- Coverage   43.65%   43.64%   -0.02%     
==========================================
  Files         217      217              
  Lines       19649    19656       +7     
==========================================
  Hits         8578     8578              
- Misses      11071    11078       +7     

Impacted Files	Coverage Δ
boa_engine/src/builtins/object/mod.rs	62.60% <0.00%> (-1.97%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b7e84d4...6d6673c. Read the comment docs.

[jedel1043]

VM implementation

Test result	main count	PR count	difference
Total	90,499	90,499	0
Passed	56,394	56,416	+22
Ignored	23,580	23,580	0
Failed	10,525	10,503	-22
Panics	0	0	0
Conformance	62.31%	62.34%	+0.02%

Fixed tests (22):

test/built-ins/Object/prototype/__defineSetter__/key-invalid.js [strict mode] (previously Failed)
test/built-ins/Object/prototype/__defineSetter__/key-invalid.js (previously Failed)
test/built-ins/Object/prototype/__defineSetter__/this-non-obj.js [strict mode] (previously Failed)
test/built-ins/Object/prototype/__defineSetter__/this-non-obj.js (previously Failed)
test/built-ins/Object/prototype/__defineSetter__/define-existing.js [strict mode] (previously Failed)
test/built-ins/Object/prototype/__defineSetter__/define-existing.js (previously Failed)
test/built-ins/Object/prototype/__defineSetter__/define-non-extensible.js [strict mode] (previously Failed)
test/built-ins/Object/prototype/__defineSetter__/define-non-extensible.js (previously Failed)
test/built-ins/Object/prototype/__defineSetter__/define-new.js [strict mode] (previously Failed)
test/built-ins/Object/prototype/__defineSetter__/define-new.js (previously Failed)
test/built-ins/Object/prototype/__defineSetter__/length.js [strict mode] (previously Failed)
test/built-ins/Object/prototype/__defineSetter__/length.js (previously Failed)
test/built-ins/Object/prototype/__defineSetter__/setter-non-callable.js [strict mode] (previously Failed)
test/built-ins/Object/prototype/__defineSetter__/setter-non-callable.js (previously Failed)
test/built-ins/Object/prototype/__defineSetter__/name.js [strict mode] (previously Failed)
test/built-ins/Object/prototype/__defineSetter__/name.js (previously Failed)
test/built-ins/Object/prototype/__defineSetter__/prop-desc.js [strict mode] (previously Failed)
test/built-ins/Object/prototype/__defineSetter__/prop-desc.js (previously Failed)
test/built-ins/Object/prototype/__defineSetter__/define-abrupt.js [strict mode] (previously Failed)
test/built-ins/Object/prototype/__defineSetter__/define-abrupt.js (previously Failed)
test/built-ins/Object/prototype/__defineSetter__/define-non-configurable.js [strict mode] (previously Failed)
test/built-ins/Object/prototype/__defineSetter__/define-non-configurable.js (previously Failed)

[Razican]

Thank you! Looks great :)

[Razican]

bors r+

[bors]

Pull request successfully merged into main.

Build succeeded:

• Clippy
• Documentation
• Examples
• Rustfmt
• Tests on Linux
• Tests on MacOS
• Tests on Windows