[Merged by Bors] - Implement Object.prototype.lookupSetter #2113

Sorck · 2022-06-11T15:06:49Z

This Pull Request closes #2067

It changes the following:

Implement Object.prototype.__lookupSetter__

This passes all tests from ./test262/test/built-ins/Object/prototype/__lookupSetter__/

Loading the test suite...
Test suite loaded, starting tests...
Suite __lookupSetter__:
`lookup-own-get-err` (strict mode): starting
`lookup-own-get-err` (strict mode): Passed
`lookup-own-get-err`: starting
`lookup-own-get-err`: Passed
`length` (strict mode): starting
`length` (strict mode): Passed
`length`: starting
`length`: Passed
`lookup-proto-proto-err` (strict mode): starting
`lookup-proto-proto-err` (strict mode): Passed
`lookup-proto-proto-err`: starting
`lookup-proto-proto-err`: Passed
`lookup-own-acsr-wo-setter` (strict mode): starting
`lookup-own-acsr-wo-setter` (strict mode): Passed
`lookup-own-acsr-wo-setter`: starting
`lookup-own-acsr-wo-setter`: Passed
`lookup-not-found` (strict mode): starting
`lookup-not-found` (strict mode): Passed
`lookup-not-found`: starting
`lookup-not-found`: Passed
`lookup-proto-acsr-wo-setter` (strict mode): starting
`lookup-proto-acsr-wo-setter` (strict mode): Passed
`lookup-proto-acsr-wo-setter`: starting
`lookup-proto-acsr-wo-setter`: Passed
`lookup-proto-acsr-w-setter` (strict mode): starting
`lookup-proto-acsr-w-setter` (strict mode): Passed
`lookup-proto-acsr-w-setter`: starting
`lookup-proto-acsr-w-setter`: Passed
`name` (strict mode): starting
`name` (strict mode): Passed
`name`: starting
`name`: Passed
`lookup-own-acsr-w-setter` (strict mode): starting
`lookup-own-acsr-w-setter` (strict mode): Passed
`lookup-own-acsr-w-setter`: starting
`lookup-own-acsr-w-setter`: Passed
`lookup-own-proto-err` (strict mode): starting
`lookup-own-proto-err` (strict mode): Passed
`lookup-own-proto-err`: starting
`lookup-own-proto-err`: Passed
`lookup-proto-data` (strict mode): starting
`lookup-proto-data` (strict mode): Passed
`lookup-proto-data`: starting
`lookup-proto-data`: Passed
`lookup-own-data` (strict mode): starting
`lookup-own-data` (strict mode): Passed
`lookup-own-data`: starting
`lookup-own-data`: Passed
`lookup-proto-get-err` (strict mode): starting
`lookup-proto-get-err` (strict mode): Passed
`lookup-proto-get-err`: starting
`lookup-proto-get-err`: Passed
`prop-desc` (strict mode): starting
`prop-desc` (strict mode): Passed
`prop-desc`: starting
`prop-desc`: Passed
`key-invalid` (strict mode): starting
`key-invalid` (strict mode): Passed
`key-invalid`: starting
`key-invalid`: Passed
`this-non-obj` (strict mode): starting
`this-non-obj` (strict mode): Passed
`this-non-obj`: starting
`this-non-obj`: Passed

Suite __lookupSetter__ results: total: 32, passed: 32, ignored: 0, failed: 0 (panics: 0), conformance: 100.00%

Results:
Total tests: 32
Passed tests: 32
Ignored tests: 0
Failed tests: 0 (panics: 0)
Conformance: 100.00%

codecov · 2022-06-11T15:24:39Z

Codecov Report

Merging #2113 (9f55cc5) into main (c9b891f) will not change coverage.
The diff coverage is 0.00%.

❗ Current head 9f55cc5 differs from pull request most recent head aa98339. Consider uploading reports for the commit aa98339 to get more accurate results

@@           Coverage Diff           @@
##             main    #2113   +/-   ##
=======================================
  Coverage   43.60%   43.60%           
=======================================
  Files         217      217           
  Lines       19684    19684           
=======================================
  Hits         8583     8583           
  Misses      11101    11101

Impacted Files	Coverage Δ
boa_engine/src/builtins/object/mod.rs	`57.36% <0.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9b891f...aa98339. Read the comment docs.

Razican · 2022-06-11T17:16:31Z

I think this is the last remaining bit, right?

raskad · 2022-06-11T17:32:34Z

VM implementation

Test result	main count	PR count	difference
Total	90,499	90,499	0
Passed	56,446	56,482	+36
Ignored	23,580	23,580	0
Failed	10,473	10,437	-36
Panics	0	0	0
Conformance	62.37%	62.41%	+0.04%

Fixed tests (36):

test/built-ins/Object/prototype/__lookupSetter__/key-invalid.js [strict mode] (previously Failed)
test/built-ins/Object/prototype/__lookupSetter__/key-invalid.js (previously Failed)
test/built-ins/Object/prototype/__lookupSetter__/lookup-own-data.js [strict mode] (previously Failed)
test/built-ins/Object/prototype/__lookupSetter__/lookup-own-data.js (previously Failed)
test/built-ins/Object/prototype/__lookupSetter__/lookup-proto-acsr-wo-setter.js [strict mode] (previously Failed)
test/built-ins/Object/prototype/__lookupSetter__/lookup-proto-acsr-wo-setter.js (previously Failed)
test/built-ins/Object/prototype/__lookupSetter__/this-non-obj.js [strict mode] (previously Failed)
test/built-ins/Object/prototype/__lookupSetter__/this-non-obj.js (previously Failed)
test/built-ins/Object/prototype/__lookupSetter__/lookup-proto-get-err.js [strict mode] (previously Failed)
test/built-ins/Object/prototype/__lookupSetter__/lookup-proto-get-err.js (previously Failed)
test/built-ins/Object/prototype/__lookupSetter__/length.js [strict mode] (previously Failed)
test/built-ins/Object/prototype/__lookupSetter__/length.js (previously Failed)
test/built-ins/Object/prototype/__lookupSetter__/lookup-own-get-err.js [strict mode] (previously Failed)
test/built-ins/Object/prototype/__lookupSetter__/lookup-own-get-err.js (previously Failed)
test/built-ins/Object/prototype/__lookupSetter__/name.js [strict mode] (previously Failed)
test/built-ins/Object/prototype/__lookupSetter__/name.js (previously Failed)
test/built-ins/Object/prototype/__lookupSetter__/prop-desc.js [strict mode] (previously Failed)
test/built-ins/Object/prototype/__lookupSetter__/prop-desc.js (previously Failed)
test/built-ins/Object/prototype/__lookupSetter__/lookup-own-proto-err.js [strict mode] (previously Failed)
test/built-ins/Object/prototype/__lookupSetter__/lookup-own-proto-err.js (previously Failed)
test/built-ins/Object/prototype/__lookupSetter__/lookup-not-found.js [strict mode] (previously Failed)
test/built-ins/Object/prototype/__lookupSetter__/lookup-not-found.js (previously Failed)
test/built-ins/Object/prototype/__lookupSetter__/lookup-proto-data.js [strict mode] (previously Failed)
test/built-ins/Object/prototype/__lookupSetter__/lookup-proto-data.js (previously Failed)
test/built-ins/Object/prototype/__lookupSetter__/lookup-proto-proto-err.js [strict mode] (previously Failed)
test/built-ins/Object/prototype/__lookupSetter__/lookup-proto-proto-err.js (previously Failed)
test/built-ins/Object/prototype/__lookupSetter__/lookup-own-acsr-wo-setter.js [strict mode] (previously Failed)
test/built-ins/Object/prototype/__lookupSetter__/lookup-own-acsr-wo-setter.js (previously Failed)
test/built-ins/Object/prototype/__lookupSetter__/lookup-own-acsr-w-setter.js [strict mode] (previously Failed)
test/built-ins/Object/prototype/__lookupSetter__/lookup-own-acsr-w-setter.js (previously Failed)
test/built-ins/Object/prototype/__lookupSetter__/lookup-proto-acsr-w-setter.js [strict mode] (previously Failed)
test/built-ins/Object/prototype/__lookupSetter__/lookup-proto-acsr-w-setter.js (previously Failed)
test/language/expressions/class/elements/private-setter-is-not-a-own-property.js [strict mode] (previously Failed)
test/language/expressions/class/elements/private-setter-is-not-a-own-property.js (previously Failed)
test/language/statements/class/elements/private-setter-is-not-a-own-property.js [strict mode] (previously Failed)
test/language/statements/class/elements/private-setter-is-not-a-own-property.js (previously Failed)

raskad

Looks great. Only needs a rebase on main and then we are ready to merge.

raskad · 2022-06-11T17:35:27Z

I think this is the last remaining bit, right?

Yes, this closes #2067

jedel1043 · 2022-06-11T17:41:11Z

Edited the description to make bors close the issue automatically

Sorck · 2022-06-11T17:52:24Z

Looks great. Only needs a rebase on main and then we are ready to merge.

Rebased against main.

jedel1043 · 2022-06-11T18:19:27Z

bors r+

This Pull Request closes #2067 It changes the following: - Implement `Object.prototype.__lookupSetter__` This passes all tests from `./test262/test/built-ins/Object/prototype/__lookupSetter__/` ``` Loading the test suite... Test suite loaded, starting tests... Suite __lookupSetter__: `lookup-own-get-err` (strict mode): starting `lookup-own-get-err` (strict mode): Passed `lookup-own-get-err`: starting `lookup-own-get-err`: Passed `length` (strict mode): starting `length` (strict mode): Passed `length`: starting `length`: Passed `lookup-proto-proto-err` (strict mode): starting `lookup-proto-proto-err` (strict mode): Passed `lookup-proto-proto-err`: starting `lookup-proto-proto-err`: Passed `lookup-own-acsr-wo-setter` (strict mode): starting `lookup-own-acsr-wo-setter` (strict mode): Passed `lookup-own-acsr-wo-setter`: starting `lookup-own-acsr-wo-setter`: Passed `lookup-not-found` (strict mode): starting `lookup-not-found` (strict mode): Passed `lookup-not-found`: starting `lookup-not-found`: Passed `lookup-proto-acsr-wo-setter` (strict mode): starting `lookup-proto-acsr-wo-setter` (strict mode): Passed `lookup-proto-acsr-wo-setter`: starting `lookup-proto-acsr-wo-setter`: Passed `lookup-proto-acsr-w-setter` (strict mode): starting `lookup-proto-acsr-w-setter` (strict mode): Passed `lookup-proto-acsr-w-setter`: starting `lookup-proto-acsr-w-setter`: Passed `name` (strict mode): starting `name` (strict mode): Passed `name`: starting `name`: Passed `lookup-own-acsr-w-setter` (strict mode): starting `lookup-own-acsr-w-setter` (strict mode): Passed `lookup-own-acsr-w-setter`: starting `lookup-own-acsr-w-setter`: Passed `lookup-own-proto-err` (strict mode): starting `lookup-own-proto-err` (strict mode): Passed `lookup-own-proto-err`: starting `lookup-own-proto-err`: Passed `lookup-proto-data` (strict mode): starting `lookup-proto-data` (strict mode): Passed `lookup-proto-data`: starting `lookup-proto-data`: Passed `lookup-own-data` (strict mode): starting `lookup-own-data` (strict mode): Passed `lookup-own-data`: starting `lookup-own-data`: Passed `lookup-proto-get-err` (strict mode): starting `lookup-proto-get-err` (strict mode): Passed `lookup-proto-get-err`: starting `lookup-proto-get-err`: Passed `prop-desc` (strict mode): starting `prop-desc` (strict mode): Passed `prop-desc`: starting `prop-desc`: Passed `key-invalid` (strict mode): starting `key-invalid` (strict mode): Passed `key-invalid`: starting `key-invalid`: Passed `this-non-obj` (strict mode): starting `this-non-obj` (strict mode): Passed `this-non-obj`: starting `this-non-obj`: Passed Suite __lookupSetter__ results: total: 32, passed: 32, ignored: 0, failed: 0 (panics: 0), conformance: 100.00% Results: Total tests: 32 Passed tests: 32 Ignored tests: 0 Failed tests: 0 (panics: 0) Conformance: 100.00% ```

bors · 2022-06-11T18:33:19Z

Pull request successfully merged into main.

Build succeeded:

jedel1043 changed the title ~~Implement Object.prototype.__lookupSetter__ #2067~~ Implement Object.prototype.__lookupSetter__ Jun 11, 2022

raskad approved these changes Jun 11, 2022

View reviewed changes

raskad added this to the v0.16.0 milestone Jun 11, 2022

raskad added enhancement New feature or request builtins PRs and Issues related to builtins/intrinsics labels Jun 11, 2022

raskad requested review from Razican, HalidOdat, jasonwilliams, jedel1043 and RageKnify June 11, 2022 17:34

Implement Object.prototype.__lookupSetter__ boa-dev#2067

aa98339

Sorck force-pushed the __lookupSetter__ branch from f7aba47 to aa98339 Compare June 11, 2022 17:51

jedel1043 approved these changes Jun 11, 2022

View reviewed changes

bors bot changed the title ~~Implement Object.prototype.__lookupSetter__~~ [Merged by Bors] - Implement Object.prototype.__lookupSetter__ Jun 11, 2022

bors bot closed this Jun 11, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Merged by Bors] - Implement Object.prototype.lookupSetter #2113

[Merged by Bors] - Implement Object.prototype.lookupSetter #2113

Sorck commented Jun 11, 2022 •

edited by jedel1043

Loading

codecov bot commented Jun 11, 2022 •

edited

Loading

Razican commented Jun 11, 2022

raskad commented Jun 11, 2022

raskad left a comment

raskad commented Jun 11, 2022

jedel1043 commented Jun 11, 2022

Sorck commented Jun 11, 2022

jedel1043 commented Jun 11, 2022

bors bot commented Jun 11, 2022

[Merged by Bors] - Implement Object.prototype.__lookupSetter__ #2113

[Merged by Bors] - Implement Object.prototype.__lookupSetter__ #2113

Conversation

Sorck commented Jun 11, 2022 • edited by jedel1043 Loading

codecov bot commented Jun 11, 2022 • edited Loading

Codecov Report

Razican commented Jun 11, 2022

raskad commented Jun 11, 2022

VM implementation

raskad left a comment

Choose a reason for hiding this comment

raskad commented Jun 11, 2022

jedel1043 commented Jun 11, 2022

Sorck commented Jun 11, 2022

jedel1043 commented Jun 11, 2022

bors bot commented Jun 11, 2022

[Merged by Bors] - Implement Object.prototype.lookupSetter #2113

[Merged by Bors] - Implement Object.prototype.lookupSetter #2113

Sorck commented Jun 11, 2022 •

edited by jedel1043

Loading

codecov bot commented Jun 11, 2022 •

edited

Loading