[Merged by Bors] - Started adding the [[Done]] field to iterators

[Razican]

This Pull Request adds the [[Done]] field to iterator records.

[Razican]

I am probably missing stuff on the VM, but I'm somehow not able to make this work :(

[raskad]

I am probably missing stuff on the VM, but I'm somehow not able to make this work :(

I'm gonna take a look, maybe I spot the error

[raskad]

I got the vm code to work. Only a few tests are missing. I'm currently looking into those.

One big change is, that the [[NextMethod]] can be a value instead of an object. Imo the spec is just wrong with the field description of [[NextMethod]]. It sounds like it can only be a function: a function object. But in GetIterator it clearly can be a value:

5. Let nextMethod be ? GetV(iterator, "next").
6. Let iteratorRecord be the Iterator Record { [[Iterator]]: iterator, [[NextMethod]]: nextMethod, [[Done]]: false }.

[github-actions]

Test262 conformance changes

VM implementation

Test result	main count	PR count	difference
Total	90,499	90,619	+120
Passed	56,837	56,859	+22
Ignored	13,648	13,788	+140
Failed	20,014	19,972	-42
Panics	0	0	0
Conformance	62.80%	62.75%	-0.06%

Fixed tests (24):

test/language/statements/for-of/iterator-close-non-object.js [strict mode] (previously Failed)
test/language/statements/for-of/iterator-close-non-object.js (previously Failed)
test/language/statements/for-of/dstr/array-elem-trlg-iter-list-nrml-close-null.js [strict mode] (previously Failed)
test/language/statements/for-of/dstr/array-elem-trlg-iter-list-nrml-close-null.js (previously Failed)
test/language/statements/for-of/dstr/array-elision-iter-nrml-close-null.js [strict mode] (previously Failed)
test/language/statements/for-of/dstr/array-elision-iter-nrml-close-null.js (previously Failed)
test/language/statements/for-of/dstr/array-elem-trlg-iter-elision-iter-nrml-close-null.js [strict mode] (previously Failed)
test/language/statements/for-of/dstr/array-elem-trlg-iter-elision-iter-nrml-close-null.js (previously Failed)
test/language/statements/for-of/dstr/array-elem-iter-nrml-close-null.js [strict mode] (previously Failed)
test/language/statements/for-of/dstr/array-elem-iter-nrml-close-null.js (previously Failed)
test/language/statements/for-of/dstr/array-empty-iter-close-null.js [strict mode] (previously Failed)
test/language/statements/for-of/dstr/array-empty-iter-close-null.js (previously Failed)
test/language/statements/try/S12.14_A12_T2.js [strict mode] (previously Failed)
test/language/statements/try/S12.14_A12_T2.js (previously Failed)
test/language/expressions/assignment/dstr/array-elem-trlg-iter-list-nrml-close-null.js [strict mode] (previously Failed)
test/language/expressions/assignment/dstr/array-elem-trlg-iter-list-nrml-close-null.js (previously Failed)
test/language/expressions/assignment/dstr/array-elision-iter-nrml-close-null.js [strict mode] (previously Failed)
test/language/expressions/assignment/dstr/array-elision-iter-nrml-close-null.js (previously Failed)
test/language/expressions/assignment/dstr/array-elem-trlg-iter-elision-iter-nrml-close-null.js [strict mode] (previously Failed)
test/language/expressions/assignment/dstr/array-elem-trlg-iter-elision-iter-nrml-close-null.js (previously Failed)
test/language/expressions/assignment/dstr/array-elem-iter-nrml-close-null.js [strict mode] (previously Failed)
test/language/expressions/assignment/dstr/array-elem-iter-nrml-close-null.js (previously Failed)
test/language/expressions/assignment/dstr/array-empty-iter-close-null.js [strict mode] (previously Failed)
test/language/expressions/assignment/dstr/array-empty-iter-close-null.js (previously Failed)

Broken tests (2):

test/language/statements/for/head-const-bound-names-in-stmt.js [strict mode] (previously Passed)
test/language/statements/for/head-const-bound-names-in-stmt.js (previously Passed)

[codecov]

Codecov Report

Merging #2125 (7e043f7) into main (31edb26) will decrease coverage by 0.02%.
The diff coverage is 39.23%.

@@            Coverage Diff             @@
##             main    #2125      +/-   ##
==========================================
- Coverage   43.50%   43.48%   -0.03%     
==========================================
  Files         220      220              
  Lines       19962    19983      +21     
==========================================
+ Hits         8684     8689       +5     
- Misses      11278    11294      +16     

Impacted Files	Coverage Δ
boa_engine/src/builtins/array_buffer/mod.rs	9.42% <0.00%> (ø)
boa_engine/src/builtins/typed_array/mod.rs	3.74% <0.00%> (ø)
boa_engine/src/context/mod.rs	32.60% <0.00%> (+0.29%)	⬆️
...gine/src/object/internal_methods/bound_function.rs	0.00% <0.00%> (ø)
boa_engine/src/object/internal_methods/mod.rs	67.96% <ø> (ø)
boa_engine/src/object/internal_methods/proxy.rs	0.00% <0.00%> (ø)
boa_engine/src/object/operations.rs	59.62% <0.00%> (-0.38%)	⬇️
boa_engine/src/vm/call_frame.rs	100.00% <ø> (ø)
boa_engine/src/vm/code_block.rs	45.81% <ø> (ø)
boa_engine/src/vm/opcode.rs	50.00% <ø> (ø)
... and 20 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31edb26...7e043f7. Read the comment docs.

[Razican]

Thanks @raskad! I will now add the logic to the Promises :)

[Razican]

The two test failures are due to changes in Test262. Not related to the PR. I think this is ready for review :)

[raskad]

Looks good to me, if we want to include the dependency updates here.

[jedel1043]

Looks good!

[jedel1043]

bors r+

[bors]

Pull request successfully merged into main.

Build succeeded:

• Clippy
• Documentation
• Examples
• Rustfmt
• Tests on Linux
• Tests on MacOS
• Tests on Windows