-
-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - Implement async function
and await
#2158
Conversation
Test262 conformance changesVM implementation
Fixed tests (705):
Broken tests (2):
|
Codecov Report
@@ Coverage Diff @@
## main #2158 +/- ##
==========================================
- Coverage 42.70% 42.43% -0.27%
==========================================
Files 225 226 +1
Lines 20793 20996 +203
==========================================
+ Hits 8879 8909 +30
- Misses 11914 12087 +173
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very much excited to merge this feature! Just some small nitpicks about the spec that don't block merging
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides the small nitpick it looks good :)
Great work @raskad
bors r+ |
Pull request successfully merged into main. Build succeeded: |
async function
and await
async function
and await
This Pull Request changes the following: - Implement `AsyncFunction` builtin object. - Add `Async` as a function object data type. - Implement `async function` and `await` compilation and execution. - Parse `await` in more positions.
This Pull Request changes the following:
AsyncFunction
builtin object.Async
as a function object data type.async function
andawait
compilation and execution.await
in more positions.