Fixed comments lexing #256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh, and I forgot to add that this PR should allow to parse multiple files in the CLI, so that we can add one after the other to the executor. This helps in #12. Please, let me know if you want any of this as a different PR. |
jasonwilliams
approved these changes
Feb 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug in comment lexing, where the initial
/was not being included in the comment token, and the line number and column numbers were wrong. This would break the numbering of a whole file if there was a multiline comment.Also, I have added the line and column numbers to the parsing errors, and properly printed them in case of failure, instead of panicking with a debug message.
This should make debugging much easier.