Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Well-Known Symbols #587

Merged
merged 5 commits into from
Jul 29, 2020
Merged

Conversation

joshwd36
Copy link
Contributor

This Pull Request closes #585.

It changes the following:

  • Moves create_intrinsics from Realm to Interpreter
  • Changes the signature of the init function from pub(crate) fn init(global: &Value) -> (&str, Value) to pub(crate) fn init(interpreter: &mut Interpreter) -> (&'static str, Value), allowing the init functions to reference the interpreter
  • Add the Well-Known Symbols to the Symbol object

@codecov
Copy link

codecov bot commented Jul 22, 2020

Codecov Report

Merging #587 into master will increase coverage by 0.15%.
The diff coverage is 96.51%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #587      +/-   ##
==========================================
+ Coverage   71.10%   71.25%   +0.15%     
==========================================
  Files         177      176       -1     
  Lines       11420    11557     +137     
==========================================
+ Hits         8120     8235     +115     
- Misses       3300     3322      +22     
Impacted Files Coverage Δ
boa/src/builtins/string/mod.rs 42.81% <ø> (-0.20%) ⬇️
boa/src/realm.rs 70.58% <ø> (+8.08%) ⬆️
boa/src/exec/mod.rs 70.79% <71.42%> (+0.56%) ⬆️
boa/src/builtins/mod.rs 23.33% <83.33%> (+2.64%) ⬆️
boa/src/builtins/array/mod.rs 80.70% <100.00%> (+0.04%) ⬆️
boa/src/builtins/bigint/mod.rs 70.00% <100.00%> (+0.50%) ⬆️
boa/src/builtins/boolean/mod.rs 36.66% <100.00%> (+2.18%) ⬆️
boa/src/builtins/console/mod.rs 29.82% <100.00%> (+0.41%) ⬆️
boa/src/builtins/error/mod.rs 36.36% <100.00%> (+3.03%) ⬆️
boa/src/builtins/error/range.rs 77.27% <100.00%> (+1.08%) ⬆️
... and 38 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bbd7dd2...e11b846. Read the comment docs.

@HalidOdat HalidOdat added builtins PRs and Issues related to builtins/intrinsics enhancement New feature or request execution Issues or PRs related to code execution labels Jul 22, 2020
Copy link
Member

@HalidOdat HalidOdat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great :)

boa/src/builtins/array/mod.rs Outdated Show resolved Hide resolved
@HalidOdat HalidOdat added this to the v0.10.0 milestone Jul 23, 2020
@joshwd36 joshwd36 marked this pull request as ready for review July 23, 2020 19:53
@Lan2u Lan2u merged commit 7b3f42d into boa-dev:master Jul 29, 2020
@joshwd36 joshwd36 deleted the Well-Known-Symbols branch July 29, 2020 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
builtins PRs and Issues related to builtins/intrinsics enhancement New feature or request execution Issues or PRs related to code execution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Well-Known Symbols
3 participants