-
-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Well-Known Symbols #587
Conversation
Codecov Report
@@ Coverage Diff @@
## master #587 +/- ##
==========================================
+ Coverage 71.10% 71.25% +0.15%
==========================================
Files 177 176 -1
Lines 11420 11557 +137
==========================================
+ Hits 8120 8235 +115
- Misses 3300 3322 +22
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great :)
This Pull Request closes #585.
It changes the following:
init
function frompub(crate) fn init(global: &Value) -> (&str, Value)
topub(crate) fn init(interpreter: &mut Interpreter) -> (&'static str, Value)
, allowing the init functions to reference the interpreter