Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature gc module #694

Merged
merged 1 commit into from
Sep 13, 2020
Merged

Feature gc module #694

merged 1 commit into from
Sep 13, 2020

Conversation

HalidOdat
Copy link
Member

It changes the following:

  • Put the gc stuff in the gc module. This cleans the root imports and adds some other gc stuff in the gc module

Instead of this

boa::{Value, Result, Trace, Finalize};

we can do this:

boa::{
	gc::{Trace, Finalize},
	Value, Result,
};

@HalidOdat HalidOdat added enhancement New feature or request API labels Sep 12, 2020
@HalidOdat HalidOdat added this to the v0.10.0 milestone Sep 12, 2020
@codecov
Copy link

codecov bot commented Sep 12, 2020

Codecov Report

Merging #694 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #694      +/-   ##
==========================================
- Coverage   71.70%   71.69%   -0.02%     
==========================================
  Files         199      199              
  Lines       13863    13865       +2     
==========================================
  Hits         9941     9941              
- Misses       3922     3924       +2     
Impacted Files Coverage Δ
boa/examples/classes.rs 0.00% <ø> (ø)
boa/src/class.rs 0.00% <ø> (ø)
boa/src/lib.rs 81.81% <ø> (ø)
boa/src/context.rs 60.79% <0.00%> (-1.06%) ⬇️
boa/src/builtins/array/mod.rs 76.65% <0.00%> (ø)
boa/src/builtins/object/mod.rs 51.19% <0.00%> (+0.60%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d5383b...a4ee1cd. Read the comment docs.

@HalidOdat HalidOdat merged commit 81089d1 into master Sep 13, 2020
@HalidOdat HalidOdat deleted the gc-module branch September 13, 2020 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant