Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Error constructors to return rather than throw #749

Merged
merged 10 commits into from
Oct 5, 2020
Merged

Fix Error constructors to return rather than throw #749

merged 10 commits into from
Oct 5, 2020

Commits on Oct 1, 2020

  1. Fix: Make SyntaxError.toString use to_string 

    SyntaxError.toString was using Value::display while all other error
types use Value::to_string
    @RageKnify
    RageKnify committed Oct 1, 2020
    Configuration menu
    Copy the full SHA
    3458b3d View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into fix/syntax_to_string

    @RageKnify
    RageKnify committed Oct 1, 2020
    Configuration menu
    Copy the full SHA
    ba2048f View commit details
    Browse the repository at this point in the history

  3. Refactor: Error constructors to return instead of "throwing" 

    Introduces some changes accross files to accommodate for the change
Fix: Correct Error.prototype.toString to use Value::to_string rather
than Value::Display
Test: Add a test case for Error Objects in Object.prototype.toString
    @RageKnify
    RageKnify committed Oct 1, 2020
    Configuration menu
    Copy the full SHA
    be659d9 View commit details
    Browse the repository at this point in the history

  4. Fix: Make Error.prototype.toString spec compliant 

    Noted by @HalidOdat in boa-dev#749
    @RageKnify
    RageKnify committed Oct 1, 2020
    Configuration menu
    Copy the full SHA
    02cd2f8 View commit details
    Browse the repository at this point in the history

  5. Test: Add a test for Error.toString

    @RageKnify
    RageKnify committed Oct 1, 2020
    Configuration menu
    Copy the full SHA
    21526fb View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2020

  1. Merge branch 'master' into fix/syntax_to_string

    @RageKnify
    RageKnify committed Oct 4, 2020
    Configuration menu
    Copy the full SHA
    91310d6 View commit details
    Browse the repository at this point in the history

  2. Refactor: Use expect rather than ? where valid

    @RageKnify
    RageKnify committed Oct 4, 2020
    Configuration menu
    Copy the full SHA
    cc9f366 View commit details
    Browse the repository at this point in the history

  3. Test: Add 2 test cases for Error.prototype.toString

    @RageKnify
    RageKnify committed Oct 4, 2020
    Configuration menu
    Copy the full SHA
    10dc0f1 View commit details
    Browse the repository at this point in the history

  4. Refactor: Change construct_$TYPE_error's return back to Value 

    Discussed in boa-dev#749
    @RageKnify
    RageKnify committed Oct 4, 2020
    Configuration menu
    Copy the full SHA
    8975e55 View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2020

  1. Clean up as suggested by @HalidOdat 

    Co-authored-by: Halid Odat <halidodat@gmail.com>
    @RageKnify @HalidOdat
    RageKnify and HalidOdat authored Oct 5, 2020
    Configuration menu
    Copy the full SHA
    d4b9824 View commit details
    Browse the repository at this point in the history