Handle invalid Unicode code point in the string literals #853
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request fixes/closes #778
It changes the following:
The lexer will no longer panic when processing the string literal with invalid Unicode code points, e.g.
"\uD83D"
. It will replace all the invalid code point with a fixed replacement char"�"
("\uFFFD"
). For example, the string"ABC\uD83D123"
will become"ABC�123"
after processing. The replacement is not revertable so the following example will not have the expected behavior:This issue can only be solved when we have the string data stored in bytes instead of chars.
This PR also fixes the unexpected behavior of handling hexadecimal and Unicode escape sequence, including: