diff --git a/pkg/reconciler/taskrun/resources/apply_test.go b/pkg/reconciler/taskrun/resources/apply_test.go index aceab4e0e6e..e60cb9cabec 100644 --- a/pkg/reconciler/taskrun/resources/apply_test.go +++ b/pkg/reconciler/taskrun/resources/apply_test.go @@ -747,101 +747,6 @@ func TestVolumeReplacement(t *testing.T) { }, }}, }, - }, { - name: "deprecated volume replacement", - ts: &v1alpha1.TaskSpec{ - Volumes: []corev1.Volume{{ - Name: "$(foo)", - }}, - }, - repl: map[string]string{"foo": "bar"}, - want: &v1alpha1.TaskSpec{ - Volumes: []corev1.Volume{{ - Name: "bar", - }}, - }, - }, { - name: "deprecated volume configmap", - ts: &v1alpha1.TaskSpec{ - Volumes: []corev1.Volume{{ - Name: "$(name)", - VolumeSource: corev1.VolumeSource{ - ConfigMap: &corev1.ConfigMapVolumeSource{ - LocalObjectReference: corev1.LocalObjectReference{ - Name: "$(configmapname)", - }, - }, - }}, - }, - }, - repl: map[string]string{ - "name": "myname", - "configmapname": "cfgmapname", - }, - want: &v1alpha1.TaskSpec{ - Volumes: []corev1.Volume{{ - Name: "myname", - VolumeSource: corev1.VolumeSource{ - ConfigMap: &corev1.ConfigMapVolumeSource{ - LocalObjectReference: corev1.LocalObjectReference{ - Name: "cfgmapname", - }, - }, - }}, - }, - }, - }, { - name: "deprecated volume secretname", - ts: &v1alpha1.TaskSpec{ - Volumes: []corev1.Volume{{ - Name: "$(name)", - VolumeSource: corev1.VolumeSource{ - Secret: &corev1.SecretVolumeSource{ - SecretName: "$(secretname)", - }, - }}, - }, - }, - repl: map[string]string{ - "name": "mysecret", - "secretname": "totallysecure", - }, - want: &v1alpha1.TaskSpec{ - Volumes: []corev1.Volume{{ - Name: "mysecret", - VolumeSource: corev1.VolumeSource{ - Secret: &corev1.SecretVolumeSource{ - SecretName: "totallysecure", - }, - }}, - }, - }, - }, { - name: "deprecated volume PVC name", - ts: &v1alpha1.TaskSpec{ - Volumes: []corev1.Volume{{ - Name: "$(name)", - VolumeSource: corev1.VolumeSource{ - PersistentVolumeClaim: &corev1.PersistentVolumeClaimVolumeSource{ - ClaimName: "$(FOO)", - }, - }, - }}, - }, - repl: map[string]string{ - "name": "mypvc", - "FOO": "pvcrocks", - }, - want: &v1alpha1.TaskSpec{ - Volumes: []corev1.Volume{{ - Name: "mypvc", - VolumeSource: corev1.VolumeSource{ - PersistentVolumeClaim: &corev1.PersistentVolumeClaimVolumeSource{ - ClaimName: "pvcrocks", - }, - }, - }}, - }, }} for _, tt := range tests { t.Run(tt.name, func(t *testing.T) {