Eliminate version query strings in font asset references #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So, does this automatically gets fixed in Bootstrap CDN some day? |
@Danger89 Sorry, this project has nothing to do with the Bootstrap CDN. Because Font-Awesome core itself includes the version numbers, I'm certain Bootstrap CDN will include them as well. You're better off taking this up with Font-Awesome core here: |
|
So you fixed an issue what isn't fixed upstream? |
Yes and no. The Rails asset pipeline has it's own mechanism for cache busting that we cannot avoid. You can read more about the underlying discussion here: #174 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #174