-
-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update webpack encore #2752
Update webpack encore #2752
Conversation
Thanks, @nestordedios 👍
We were getting these already! They need to be fixed, but that can/should be done in a separate PR! |
You are welcome @bobdenotter . I wasn't aware of that. I think it's Bootstrap the one making so much noise. In the Bootstrap repository they seem to have this issue and they suggest to downgrade sass to It seems it is fixed for Bootstrap v5 but not for v4. Maybe it will get fix for Bootstrap v4 as well twbs/bootstrap#34245 (comment). Let's keep an eye on it. |
Or, alternatively, see if we can update to Bootstrap 5.1 soon-ish. 👍 (but, both can come in follow-up PR's) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Nice!! Yes I'll look into Bootstrap migration and open a separate PR for that. |
Fixes #2578 .
This PR updates Webpack Encore from v0.31 to v1.5.
The downside of this upgrade is that when running
npm run build
we get a lot of warning messages in the console like: