Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix clippy warnings & added gitignore #2

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

DuckyBlender
Copy link

  • Fixed most clippy pedantic warnings
  • Added .gitignore
  • Removed cargo.lock (it's useless)
  • Shortened some code
  • Ignore false positives in every file
  • Added a commented function to interpolate between two colors. I experimented with interpolating the first nodes but in my opinion it is less readable. Up to preference.

Program works exactly the same
Thank you for this project, I was able to learn a ton of stuff reading this code :)

@bones-ai
Copy link
Owner

bones-ai commented Dec 4, 2023

Thanks for the PR :)
Also apologies for the super late reply

Thanks for the updates you've to the project, just one request, there are a few functions in car.rs like car_manual_input_system and car_steer_system that enable the user to drive the car around the screen and I would really like to retain that feature without having the uncomment the code again (just uncommenting the systems).

I'll spend some time over the next weekend to make minor updates to the PR before merging it

@DuckyBlender
Copy link
Author

Apologies for the super super late reply. Sure, will do

@DuckyBlender
Copy link
Author

will also update bevy :)

@DuckyBlender DuckyBlender marked this pull request as draft April 12, 2024 20:31
@DuckyBlender
Copy link
Author

will also update bevy :)

unfortunately, only one version up (0.11) because some bevy crates don't yet support the newest version... just the nature of such a dynamic project

@DuckyBlender DuckyBlender marked this pull request as ready for review April 12, 2024 21:01
@DuckyBlender
Copy link
Author

ready for review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants