From b9af2430347618ec7726cb6d746ff6886462e449 Mon Sep 17 00:00:00 2001
From: Duncan <bonsairobo@gmail.com>
Date: Mon, 26 Oct 2020 12:17:39 -0700
Subject: [PATCH] add some TODOs, and fix a broken benchmark

---
 crates/building_blocks_storage/benches/compression.rs | 4 +++-
 crates/building_blocks_vox/src/lib.rs                 | 1 +
 2 files changed, 4 insertions(+), 1 deletion(-)

diff --git a/crates/building_blocks_storage/benches/compression.rs b/crates/building_blocks_storage/benches/compression.rs
index acb37e05..26defd17 100644
--- a/crates/building_blocks_storage/benches/compression.rs
+++ b/crates/building_blocks_storage/benches/compression.rs
@@ -1,5 +1,5 @@
 use building_blocks_core::prelude::*;
-use building_blocks_storage::prelude::*;
+use building_blocks_storage::{prelude::*, BincodeLz4};
 
 use criterion::{criterion_group, criterion_main, BenchmarkId, Criterion};
 
@@ -50,3 +50,5 @@ fn set_up_array(size: i32) -> Array3<i32> {
         p.x() % 3 + p.y() % 3 + p.z() % 3
     })
 }
+
+// TODO: report the compression efficiency for some typical data set, like a sphere
diff --git a/crates/building_blocks_vox/src/lib.rs b/crates/building_blocks_vox/src/lib.rs
index edb281de..c964fbd0 100644
--- a/crates/building_blocks_vox/src/lib.rs
+++ b/crates/building_blocks_vox/src/lib.rs
@@ -9,6 +9,7 @@ pub enum VoxColor {
     Empty,
 }
 
+// TODO: should take a type parameter that implements a trait to access `VoxColor`
 pub fn encode_vox(map: &Array3<VoxColor>) -> DotVoxData {
     let global_extent = *map.extent();
     let local_extent = global_extent - global_extent.minimum;