This repository has been archived by the owner on May 3, 2022. It is now read-only.
WIP: Hilla/gradual rollout v2 #308
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hihilla
force-pushed
the
hilla/gradual-rollout-v2
branch
from
4c27c5f to
80466e6
Compare
juliogreff
reviewed
Apr 10, 2020
| { | ||
| VirtualSteps: []shipper.RolloutStrategyStep{ | ||
| { | ||
| Name: "0: to staging", |
There was a problem hiding this comment.
I wonder, why do we care about giving virtual strategy steps a name? This should be mostly an internal concern, and I don't expect it to aid debugging. Thoughts?
There was a problem hiding this comment.
I tend to agree, but when debugging I looked both at the numbers and at the title
after some more refactoring, I will test it again and see if the title actually helps me
hihilla
force-pushed
the
hilla/gradual-rollout-v2
branch
3 times, most recently
from
1c13aaa to
fc3d777
Compare
hihilla
force-pushed
the
hilla/gradual-rollout-v2
branch
from
16f6e06 to
554a911
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a wip
Will close #124