Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fuzz to_chars for integers #185

Merged
merged 2 commits into from
Apr 19, 2024
Merged

Fuzz to_chars for integers #185

merged 2 commits into from
Apr 19, 2024

Conversation

mborland
Copy link
Member

Fixes buffer overflows since the calculations of the user buffer size did not account for a negative sign.

Copy link

codecov bot commented Apr 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.17%. Comparing base (552b5b5) to head (2ba5773).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #185   +/-   ##
========================================
  Coverage    93.17%   93.17%           
========================================
  Files           65       65           
  Lines         8396     8396           
========================================
  Hits          7823     7823           
  Misses         573      573           
Files Coverage Δ
...de/boost/charconv/detail/to_chars_integer_impl.hpp 96.89% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 552b5b5...2ba5773. Read the comment docs.

@mborland mborland merged commit 92f714f into develop Apr 19, 2024
63 checks passed
@mborland mborland deleted the more_fuzz branch April 19, 2024 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant