Adding wchar_t* file name support for file_mapping constructor #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wingfiring
changed the title
|
+1 for unicode windows file names. |
|
Is there any specific reason this PR has not been merged in? We're having some trouble with file paths that contain unicode as well and its becoming a pain to maintain multiple codepaths to handle native support on every build configuration we target. Its one of the few areas where we cannot be truly xplat right now. |
|
The same limitation applies to boost::interprocess::sync::file_lock. This patch adds support for wide character file paths in this class: |
|
How can I vote for this patch? |
|
+1 for unicode windows file names. |
|
Finally wide filename support for Windows was added in commit: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I'm a developer from Autodesk.
More and more peoples in our company want to use file mapping cross platforms, but file_mapping of boost.interprocess lacks of wide char file name supporting on Windows. I think it's valuable for us to support wide char file name.
-Jackson