build-sys: Some Cargo.toml cleanups #1501
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
General cleanup. Signed-off-by: Colin Walters <walters@verbum.org>
Split `dependencies` into three sections: - Internal deps (crates in the same workspace) - Workspace deps - Deps only used by that sub-crate Also make everything alphabetical. Assisted-by: Claude Code Signed-off-by: Colin Walters <walters@verbum.org>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request does a great job of cleaning up the Cargo.toml files by moving dependencies to the workspace and organizing them. The changes improve consistency and maintainability across the project. I've found a few dependencies in crates/ostree-ext/Cargo.toml that were missed and could also be moved to use the workspace definition. I've provided a suggestion to address this.
Signed-off-by: Colin Walters <walters@verbum.org>
jeckersb
approved these changes
Aug 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.