Add find_manifest_descriptor_with_tag #28
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
@cgwalters could you please take a look? |
cgwalters
approved these changes
Oct 11, 2024
Collaborator
cgwalters
left a comment
cgwalters
left a comment
There was a problem hiding this comment.
Looks sane to me; would be nice to have a unit test but I won't block on that.
cgwalters
reviewed
Oct 11, 2024
Refactor find_manifest_with_tag to use this new function. Signed-off-by: Ariel Miculas-Trif <amiculas@cisco.com>
…ndex> The index.json file MUST exist according to the OCI Image Layout Spec [1], thus read_index should return the ImageIndex directly, there's no need to wrap it into an Option. [1] https://github.com/opencontainers/image-spec/blob/main/image-layout.md Signed-off-by: Ariel Miculas-Trif <amiculas@cisco.com>
ariel-miculas
force-pushed
the
add-helper-functions
branch
from
5fbc15d to
7f58190
Compare
cgwalters
approved these changes
Oct 12, 2024
Collaborator
Author
|
Thanks, @cgwalters! Is there anything else in the backlog before releasing 0.4? I would have liked to address #27, but I feel like my ideas are too convoluted. |
Collaborator
We should probably review #29 right? |
ariel-miculas
added a commit
to ariel-miculas/puzzlefs
that referenced
this pull request
Oct 14, 2024
Now that [1] was merged, we can use find_manifest_descriptor_with_tag and remove copy-pasted code from ocidir-rs. [1] bootc-dev/ocidir-rs#28 Signed-off-by: Ariel Miculas-Trif <amiculas@cisco.com>
TacitGlad
added a commit
to TacitGlad/NewFileSystem
that referenced
this pull request
Mar 5, 2025
Now that [1] was merged, we can use find_manifest_descriptor_with_tag and remove copy-pasted code from ocidir-rs. [1] bootc-dev/ocidir-rs#28 Signed-off-by: Ariel Miculas-Trif <amiculas@cisco.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor find_manifest_with_tag to use this new function.