Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Festival backend ignores apostrophes #12

Closed
yvt opened this issue Aug 21, 2018 · 4 comments
Closed

Festival backend ignores apostrophes #12

yvt opened this issue Aug 21, 2018 · 4 comments
Labels

Comments

@yvt
Copy link

yvt commented Aug 21, 2018

$ echo "I'm looking for a job as a digital assistant." | phonemize
ihm luhkaxng faor ax jhaab aez ax dihjhaxtaxl axsihstaxnt

$ echo "Im looking for a job as a digital assistant." | phonemize
ihm luhkaxng faor ax jhaab aez ax dihjhaxtaxl axsihstaxnt
@mmmaat
Copy link
Collaborator

mmmaat commented Aug 27, 2018

Hi,

This is not a bug but the expected behavior. The apostrophe is not displayed but pronounced... For example:

def test_its():
assert _test("it's") == ['ih-t-s']
assert _test("its") == ['ih-t-s']
assert _test("it s") == ['ih-t eh-s']
assert _test('it "s') == ['ih-t eh-s']

@mmmaat mmmaat closed this as completed Aug 27, 2018
@yvt
Copy link
Author

yvt commented Aug 28, 2018

So you are saying, in contrary to what most people and New Oxford American Dictionary say (I'm |aɪm|), "I'm" being pronounced as |ɪm| as in "image" and "imitate" is an expected behavior?

@mmmaat
Copy link
Collaborator

mmmaat commented Aug 28, 2018

Ok thank you for pointing out that bug, because it is a bug I recently introduced... In a former version we had:

$ echo "I'm looking for an image." | phonemize
aym luhkaxng faor axn ihmaxjh
$ echo "Im looking for an image." | phonemize
ihm luhkaxng faor axn ihmaxjh 

In the latest release we have:

$ echo "I'm looking for an image." | phonemize
ihm luhkaxng faor axn ihmaxjh
$ echo "Im looking for an image." | phonemize
ihm luhkaxng faor axn ihmaxjh 

I will correct that very soon. Note that the bug concerns only the festival backend, you can still use the espeak one:

$ echo "I'm looking for an image." | phonemize -l en-gb
aɪm lʊkɪŋ fəɹən ɪmɪdʒ
$ echo "Im looking for an image." | phonemize -l en-gb
ɪm lʊkɪŋ fəɹən ɪmɪdʒ

@mmmaat mmmaat reopened this Aug 28, 2018
@mmmaat mmmaat added the bug label Aug 28, 2018
@mmmaat
Copy link
Collaborator

mmmaat commented Aug 28, 2018

Fixed in commit a2af480

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants