Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modelserver - Client: Failed update discrepancy #150

Closed
haydar-metin opened this issue Nov 27, 2023 · 1 comment
Closed

Modelserver - Client: Failed update discrepancy #150

haydar-metin opened this issue Nov 27, 2023 · 1 comment
Labels
bug Something isn't working modelserver

Comments

@haydar-metin
Copy link
Collaborator

Assume you move a node to position 20 from origin 10. However, in the model server it is not allowed and therefore the node will stay on position 10 - there is no update to the unnotation file -> thus no changes will be sent to the GLSP-Server, and consequently the client will have for the node the invalid position of 20 until it retrieves the whole model again.

Temp Workaround:
com.eclipsesource.uml.modelserver.core.controller.UmlSessionController.commandExecuted(String, Supplier<? extends CCommandExecutionResult>, Supplier<Map<URI, JsonNode>>) introduced in #149

Classes that cause this behavior:

  • org.eclipse.emfcloud.modelserver.emf.util.JsonPatchHelper.getJsonPatches(EObject, CCommandExecutionResult)
  • ...

Find a better solution, e.g.:

  • Make the client more safe (e.g., movement restrictor)
  • Send always the modified delta

and remove the current workaround

@haydar-metin haydar-metin added bug Something isn't working modelserver labels Nov 27, 2023
@haydar-metin
Copy link
Collaborator Author

Modelserver has been removed from architecture

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working modelserver
Projects
None yet
Development

No branches or pull requests

1 participant