Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add composer.lock #494

Merged
merged 2 commits into from
Oct 30, 2020
Merged

Add composer.lock #494

merged 2 commits into from
Oct 30, 2020

Conversation

villfa
Copy link
Contributor

@villfa villfa commented Oct 30, 2020

@smoench I push the composer.lock I had on my machine since the last time I worked on Box. Hopefully the build should pass with it.

@smoench
Copy link
Contributor

smoench commented Oct 30, 2020

Does it also includes the changes in php-scoper for composer v2?

@villfa
Copy link
Contributor Author

villfa commented Oct 30, 2020

No, it doesn't. It uses php-scoper 0.13.5.
I think we could upgrade it later when the build will be stable.

[EDIT]: sorry I misread your question. So yes 0.13.5 includes the changes for composer v2.

@villfa villfa marked this pull request as ready for review October 30, 2020 12:31
@villfa
Copy link
Contributor Author

villfa commented Oct 30, 2020

Well there is still a test failing because of composer v2: make e2e_symfony
I'm not sure how to fix it yet...

@smoench
Copy link
Contributor

smoench commented Oct 30, 2020

Symfony flex needs to be updated to the latest version (1.9.10) for this test case

@villfa
Copy link
Contributor Author

villfa commented Oct 30, 2020

@theofidry the build is green again :)

@theofidry theofidry merged commit 563fffb into box-project:master Oct 30, 2020
@theofidry
Copy link
Member

Thank you!

@villfa villfa deleted the composer-lock branch October 30, 2020 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants