Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Composer1 related code #592

Merged
merged 4 commits into from
Jan 31, 2022

Conversation

theofidry
Copy link
Member

No description provided.

@theofidry theofidry merged commit c4f5f1b into box-project:master Jan 31, 2022
@theofidry theofidry deleted the feature/remove-composer-1 branch January 31, 2022 23:56
@llaville
Copy link
Contributor

Removing Composer v1 (👍 of course), but adding a so restrictive constraint to plugin API "composer-plugin-api": "^2.2".
Is it really necessary ?
I know that Composer 2.2 is now the new LTS and recommended version, but platforms that still have Composer 2.1 are not able to use box 3.15

devilbox@php-7.4.27 in /shared/backups/github/my-box $ composer update
Loading composer repositories with package information
Updating dependencies
Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - Root composer.json requires composer-plugin-api ^2.2, found composer-plugin-api[2.1.0] but it does not match the constraint.

Consider it as a warning, nothing else. I'm personally be able to update my local platform to Composer 2.2

@theofidry
Copy link
Member Author

I am not sure to be honest. There was a few hiccups with 2.0 to 2.2 because some (internal) files changed and this was affecting Box. So unless someone is willing to add back 2.1 and 2.0 to the build matrix and adapt the tests (as I expect some will need changes), I think it's best to stick to 2.2. At the very least I think it's a lot simpler to run a composer self update command than start this endeavor ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants