From 742780613a0ffaceada34591d8d6d77039aeca9a Mon Sep 17 00:00:00 2001 From: Adrien Loison Date: Tue, 28 Mar 2017 14:36:15 +0200 Subject: [PATCH] Do not add space between text nodes (#401) --- .../XLSX/Helper/SharedStringsHelper.php | 5 ----- ...ining_text_and_hyperlink_in_same_cell.xlsx | Bin 5127 -> 5560 bytes 2 files changed, 5 deletions(-) diff --git a/src/Spout/Reader/XLSX/Helper/SharedStringsHelper.php b/src/Spout/Reader/XLSX/Helper/SharedStringsHelper.php index 4d97ee45..a334bb1c 100644 --- a/src/Spout/Reader/XLSX/Helper/SharedStringsHelper.php +++ b/src/Spout/Reader/XLSX/Helper/SharedStringsHelper.php @@ -234,11 +234,6 @@ protected function extractTextValueForNodes($textNodes) $textValue = ''; foreach ($textNodes as $nodeIndex => $textNode) { - if ($nodeIndex !== 0) { - // add a space between each "t" node - $textValue .= ' '; - } - $textNodeAsString = $textNode->__toString(); $shouldPreserveWhitespace = $this->shouldPreserveWhitespace($textNode); diff --git a/tests/resources/xlsx/one_sheet_with_shared_strings_containing_text_and_hyperlink_in_same_cell.xlsx b/tests/resources/xlsx/one_sheet_with_shared_strings_containing_text_and_hyperlink_in_same_cell.xlsx index 08527df059d8834bb505d187725ae18d47f69979..8de03588cb6fed0fad548b96c18e575dfa54d172 100644 GIT binary patch delta 2226 zcmZqI*r6>E;LXe;!oa}5!BFkC$wRWWBh!+Rf#D|0=KuU5j8+gi28O8O8ZV$CIA8;^ z;)_yqiuF$z*{s1Uv%`{Qsvn?*&oIn*R`N;uA`32|(Y*~Fk;SEr_mT|KoBMYM# zvg6o4Zr@S>blg{_&CyJqjDEO`X9nu8$bq{I)AbKtJ~z z2EAegTB*!5`3#>_{nm-+{SF)O9D85gb)tM$9(&6&v&$`0jM*z1biUs5_!<0YOOlQ4 zIkr0j>@Fg%pY+T2o%buR;Er1}oWE_x-A|W(y{`+AmH+t1EqvM2 zD>p>yHhz@<+kJDf;-9c-rGF;bM@r|~F`&k`aLbvf6-*2ai9(a(*+uIw=G|5hX?y=& zq~rHhzgbJ(rtHqLuDo?NWbI0m%v-D*H}-ZNWV&>$_LpqW;~Ohi>8{+eG^mLAk6q0l z8HIzKdf}?>{UMoZt{v{`c5WdmMyX2tAOG6?tLU3(=CY*4+tE2DxL1EMf1{b{@^aRt zY>bXC1jLVp%(wAZXVvYrnB6`uzh0;i4i zdfhr>xR}kXICnnE=6aOVH1Y7=6C!JB7B*=e+9=K%$KBE7)5V+KHCKT3m!z!_pTPY# z?x3LS`-0908U-1}Sr_KCE>ZA0{3d35nn3$4<`?oM-(8AUPB0C8NUd0V{x#RNkOOMPGt}PkU)-tmHN)m@X$F@>xnd~S>|Og8 z&S?p9E7IiHzusw%;5yBBOU{4tTys?8fr&9gn2vrvi!u)!+ESzd_Q`@fJ^Uxn9<4Wf{B`~NcSiSj zAMgLR_t^SP)6e~`yO;4-_Rh<_W>fcyFVS0Td?$Ef?N6SM=D)X{ubvsLBWdolWo^pJ zM5XI~uY0%l?wpwFd2PzYk_OAWg3Wcm_FG-aX_)o4A<9|H)itPm$!5mPP1czYUe`ES z|E|8J8_Kz+f_;}n!?N|wX6|fa*Khx^6#2`BnvNHqiQM@Qn9oa@H>ZAjKDd+~sAR`yCa3^~f&Y%vfdv3kaSk&UQllUWbOr_im>wX#t#Kc+ zw)(_^0#u(sv?I!V1_nVC?Kgm-1h+LgzbF+|J7z$Dss$MM?^wO4jVXU)Ha#5z98@vN+4rAbOfRS}L+qEU8Cl;ih-V?PX8aF&$Q)^4YrDNp92G zH?!{F~3Gv~-%(tny#5|F3H{xq$|BTw(&X36#SwdK=)-m|US^4_#=>fW+@ z-#`1kmVe;)e(TEmH+vOIGv_{>*Y)OfdPn_@?X~w#-$^>TBXLo#syDCj&a$ZdHMwVc zb-Xt%>siKp=4GG6m(&06E=*&-lEZ!_NKzIAi|<-C<%2}i9j z9Az-6mEK}$v|-1+XXh8b;1BR-=MZi=6SWeUArgfU30(jq4;S!024)})QMsi%fJt5# zU%t%bi(&?ud;fF^ql4CRM+7;z7S73Ic8K?N}e?y?l32;&NHCk45zb z_8Chz>v9@QotYOiKdzuOUz*>G<7ACN&6DM~_a0x+H{)jTtFOy4w;p zO%_m4GBSxUfXdm)4nlI$Kofu$xjX_$}cF^Pb??^ zl~PEG9x#jXfXx6C&P}HUSy|fb4@lE)q+Z;iOK=P!i0NrE}xVR z!UYi1;Xw=Zxd_5&AZrWX