Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Add support for newer versions of PHP. #177

Merged
merged 1 commit into from
Mar 1, 2022

Conversation

jenkoian
Copy link
Contributor

Allow the building against different versions of PHP, including:

  • 7.4
  • 8.0
  • 8.1

As the project could be built against any of these versions it no longer
makes sense to ship a composer.lock file and thus this has been
removed.

@jenkoian jenkoian force-pushed the support-newer-php-versions branch 4 times, most recently from 4ffc385 to 562bc2b Compare February 25, 2022 11:15
@jenkoian jenkoian marked this pull request as ready for review February 25, 2022 11:17
@andrewjt71
Copy link

If we are opening this up to multiple versions of php, should travis builds be added for some of those versions?

@jenkoian
Copy link
Contributor Author

@andrewjt71 yep! Will do that now thanks

@jenkoian jenkoian force-pushed the support-newer-php-versions branch 2 times, most recently from d5fa8cc to 6823612 Compare March 1, 2022 11:37
@jenkoian jenkoian closed this Mar 1, 2022
@jenkoian jenkoian reopened this Mar 1, 2022
@jenkoian jenkoian force-pushed the support-newer-php-versions branch from 3f8ff90 to ab8e689 Compare March 1, 2022 12:09
Allow the building against different versions of PHP, including:

* 7.4
* 8.0
* 8.1

As the project could be built against any of these versions it no longer
makes sense to ship a `composer.lock` file and thus this has been
removed.
@jenkoian jenkoian force-pushed the support-newer-php-versions branch from ab8e689 to e7cc91f Compare March 1, 2022 12:17
@jenkoian
Copy link
Contributor Author

jenkoian commented Mar 1, 2022

@andrewjt71 whenever I amend the travis file, travis errors, even if it's a benign change, so I'm going to merge this and do it in a follow up PR.

@jenkoian jenkoian merged commit e2daf98 into main Mar 1, 2022
@jenkoian jenkoian deleted the support-newer-php-versions branch March 1, 2022 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants