[REFACTOR] Use dictator as a WP-CLI package. #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 14, 2022 15:08
Rather than a composer package which opens us up to dependency clashes use dictator as a WP-CLI package. One thing with this is if using dictator as part of deploy, we'll need to make sure we install the package this way as well rather than relying on composer.
We want to ensure plugin versions are locked so therefore do not ignore the composer.lock file. Also adds a note to the PHP versions docs about what to do if changing PHP versions and faced with composer version issues.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than a composer package which opens us up to dependency clashes
use dictator as a WP-CLI package.
One thing with this is if using dictator as part of deploy, we'll need
to make sure we install the package this way as well rather than relying
on composer.