[SETUP] Make use of docker-compose profiles. #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use [docker-compose profiles](https://docs.docker.com/compose/profiles/) for starting up additional services such as blackfire for profiling and backstop for visual-regression testing. Unfortunately due us needing to extend nginx we can't use this for styleguide due to the following not being support in v3 of docker-compose: https://docs.docker.com/compose/extends/#extending-services well we probably still could but we'd need to bring up with the mutliple docker-compose files as well so little point just yet. https://docs.docker.com/compose/extends/#extending-services
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use docker-compose profiles
for starting up additional services such as blackfire for profiling and
backstop for visual-regression testing.
Unfortunately due us needing to extend nginx we can't use this for
styleguide due to the following not being support in v3 of
docker-compose:
https://docs.docker.com/compose/extends/#extending-services well we
probably still could but we'd need to bring up with the mutliple
docker-compose files as well so little point just yet.
https://docs.docker.com/compose/extends/#extending-services