Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update eslint* dependencies (major) #40

Merged
merged 2 commits into from
Oct 11, 2024
Merged

chore: update eslint* dependencies (major) #40

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
235125c
chore: update eslint* dependencies
renovate[bot] Oct 11, 2024
bc14c5b
chore: migrate to eslint@9
barmac Oct 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .eslintignore
View file
Open in desktop

This file was deleted.

3 changes: 0 additions & 3 deletions .eslintrc
View file
Open in desktop

This file was deleted.

24 changes: 24 additions & 0 deletions eslint.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
import bpmnIoPlugin from 'eslint-plugin-bpmn-io';

export default [
{
ignores: [
'dist'
]
},
...bpmnIoPlugin.configs.recommended,
...bpmnIoPlugin.configs.mocha.map(config => {
return {
...config,
files: [
'test/**/*.js'
],
languageOptions: {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From my point of view better:

Just have a separate configuration with "additional test changes" to be merged with the previosu config, cf. bpmn-io/diagram-js@85027fe

➡️ ESLint does the merging already, I don't see why we need to do it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0489d45

globals: {
...config.languageOptions.globals,
require: false
}
}
};
})
];
Loading