Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CLOSED] Remove the use of the viewport hack #6442

Open
core-ai-bot opened this issue Aug 30, 2021 · 3 comments
Open

[CLOSED] Remove the use of the viewport hack #6442

core-ai-bot opened this issue Aug 30, 2021 · 3 comments

Comments

@core-ai-bot
Copy link
Member

Issue by TomMalbran
Friday Mar 07, 2014 at 04:13 GMT
Originally opened as adobe/brackets#7118

Since #3115 is now fixed, I removed the use of the viewport hack used to properly calculate the height of the editor. This also fixes scroll adjustment when changing the font, which was using the viewport hack and stopped working when #3115 was fixed.

TomMalbran included the following code: https://github.com/adobe/brackets/pull/7118/commits
@core-ai-bot
Copy link
Member Author

Comment by RaymondLim
Friday Mar 07, 2014 at 04:53 GMT

Reviewing...

This viewport hack is the real culprit of #7093. I verified that removing this hack fix the #7093.

@core-ai-bot
Copy link
Member Author

Comment by RaymondLim
Friday Mar 07, 2014 at 06:41 GMT

Looks good and all the integration tests for ViewCommandHandlers pass. Merging.

@core-ai-bot
Copy link
Member Author

Comment by TomMalbran
Friday Mar 07, 2014 at 06:42 GMT

Oh, I was going to submit a fix for the issue I mentioned... new PR I guess.

@core-ai-bot core-ai-bot mentioned this issue Aug 31, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@core-ai-bot