Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLOSED] Changes to allow backward compatibility with plain ole CodeMirror themes #7758

Open
core-ai-bot opened this issue Aug 30, 2021 · 0 comments

Comments

@core-ai-bot
Copy link
Member

Issue by MiguelCastillo
Wednesday Aug 06, 2014 at 04:41 GMT
Originally opened as adobe/brackets#8673


Loading theme files directly instead of a package breaks old themes; e.g. vanilla codemirror themes. The issue is caused by adding the file extension as part of the theme name. This logic was to handle edge cases when themes had the same filename but different extensions, but this edge case should really be resolved by giving files a better name. This was important in earlier impls of themes that provided an interface to load all the theme files in a diretory (loadDirectory) but that interface was removed a while ago.


MiguelCastillo included the following code: https://github.com/adobe/brackets/pull/8673/commits

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant