Daskify Stats #70
Merged
Daskify Stats #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bradyrx
added
bug
|
This example from Ryan could potentially help: |
This was referenced Dec 3, 2019
|
This looks massive and great. Looking forward to review this once it is ready. |
|
I'll tag you to review once it's done! Just doing this in surges when I have energy. But should be really robust and have all the dask support we need. |
|
See here: https://github.com/scipy/scipy/blob/47ffc1e/scipy/stats/stats.py#L2767-L2882 They call it |
|
from |
This was referenced Jun 30, 2020
aaronspring
reviewed
Jul 4, 2020
add docstrings through utils add DAYS_PER_YEAR constant
reorganize ci env
Consolidate regression testing suite. use parametrize to compress testing even more with various time types
* update xarray decorator to is_xarray, and other small dev fixes move get_dims to utils move fixtures to conftest add testing for linear_slope
only show units warning for slopes remove has_dims
automatically convert slopes by factor
add timeutils accessor testing add test for match_nans add tests for missing data in x axis
|
Went ahead and merged @aaronspring, since you reviewed this extensively. |
This was referenced Jul 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Cleans up the
statsmodule using simplynumpyfunctions and adds explicitdasksupport with testing.Fixes #66, #65, #31, #63
Type of change
Please delete options that are not relevant.
To Do List
How Has This Been Tested?
Checklist (while developing)
pytest, if necessary.Pre-Merge Checklist (final steps)
make htmlon the documents to make sure example notebooks still compile.References
Please add any references to manuscripts, textbooks, etc.