Remove Duplicate episodes and enforce the rule (#525)

brand-it · Dec 10, 2024 · e711d65 · e711d65
1 parent f18a358
commit e711d65
Show file tree

Hide file tree

Showing 5 changed files with 23 additions and 4 deletions.
diff --git a/app/models/episode.rb b/app/models/episode.rb
@@ -18,7 +18,8 @@
 #
 # Indexes
 #
-#  index_episodes_on_season_id  (season_id)
+#  index_episodes_on_season_id        (season_id)
+#  index_episodes_on_the_movie_db_id  (the_movie_db_id) UNIQUE
 #
 class Episode < ApplicationRecord
   include ActionView::Helpers::DateHelper
@@ -30,6 +31,7 @@ class Episode < ApplicationRecord
   has_many :uploaded_video_blobs, -> { uploaded }, class_name: 'VideoBlob', dependent: false, inverse_of: :episode
 
   validates :episode_number, presence: true
+  validates :the_movie_db_id, uniqueness: true
 
   scope :order_by_episode_number, -> { order(:episode_number) }
 

diff --git a/db/migrate/20241210214438_remove_dups_from_episodes.rb b/db/migrate/20241210214438_remove_dups_from_episodes.rb
@@ -0,0 +1,14 @@
+class RemoveDupsFromEpisodes < ActiveRecord::Migration[7.2]
+  def change
+    Episode.find_each do |episode|
+      episodes = Episode.where(the_movie_db_id: episode.the_movie_db_id)
+      if episodes.size > 1
+        episodes.each.with_index do |dup, index|
+          next if index.zero?
+          dup.destroy
+        end
+      end
+    end
+    add_index :episodes, [:the_movie_db_id], if_not_exists: true, unique: true
+  end
+end
diff --git a/db/schema.rb b/db/schema.rb
@@ -10,7 +10,7 @@
 #
 # It's strongly recommended that you check this file into your version control system.
 
-ActiveRecord::Schema[7.2].define(version: 2024_11_23_005122) do
+ActiveRecord::Schema[7.2].define(version: 2024_12_10_214438) do
   create_table "configs", force: :cascade do |t|
     t.string "type", default: "Config", null: false
     t.text "settings"
@@ -70,6 +70,7 @@
     t.bigint "season_id"
     t.integer "runtime"
     t.index ["season_id"], name: "index_episodes_on_season_id"
+    t.index ["the_movie_db_id"], name: "index_episodes_on_the_movie_db_id", unique: true
   end
 
   create_table "jobs", force: :cascade do |t|

diff --git a/spec/factories/episodes.rb b/spec/factories/episodes.rb
@@ -18,7 +18,8 @@
 #
 # Indexes
 #
-#  index_episodes_on_season_id  (season_id)
+#  index_episodes_on_season_id        (season_id)
+#  index_episodes_on_the_movie_db_id  (the_movie_db_id) UNIQUE
 #
 FactoryBot.define do
   factory :episode do

diff --git a/spec/models/episode_spec.rb b/spec/models/episode_spec.rb
@@ -18,7 +18,8 @@
 #
 # Indexes
 #
-#  index_episodes_on_season_id  (season_id)
+#  index_episodes_on_season_id        (season_id)
+#  index_episodes_on_the_movie_db_id  (the_movie_db_id) UNIQUE
 #
 require 'rails_helper'