Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup embedme.top rules #2156

Merged
merged 1 commit into from
Nov 16, 2024
Merged

Cleanup embedme.top rules #2156

merged 1 commit into from
Nov 16, 2024

Conversation

ryanbr
Copy link
Collaborator

@ryanbr ryanbr commented Nov 16, 2024

Sync with uBO rules

@ryanbr ryanbr added the cleanup label Nov 16, 2024
@ryanbr ryanbr self-assigned this Nov 16, 2024
@ryanbr ryanbr merged commit fe9073f into master Nov 16, 2024
6 checks passed
@ryanbr ryanbr deleted the embbedds branch November 16, 2024 03:30
Copy link

[puLL-Merge] - brave/adblock-lists@2156

Description

This pull request updates the adblock rules in the brave-unbreak.txt file. The main changes involve removing embedme.top from a large list of domains and adding specific rules for embedme.top at the end of the file.

Changes

Changes

  1. In brave-unbreak.txt:
    • Removed embedme.top from a long list of domains that use the ##+js(nowoif) rule.
    • Removed embedme.top from another long list of domains that use the ##+js(rmnt, script, break;case $.) rule.
    • Added specific rules for embedme.top at the end of the file:
      embedme.top##+js(abort-current-script, JSON.parse, showTrkURL)
      embedme.top##+js(abort-current-script, Math, /window\['(?:\\x[0-9a-f]{2}){2}/)
      embedme.top##+js(noeval-if, /popunder/i)
      embedme.top##+js(abort-current-script, document.documentElement, break;case $.)
      

Possible Issues

No major issues are apparent in this change. The modifications appear to be routine updates to the adblock rules, targeting specific behavior on the embedme.top domain.

Security Hotspots

There are no obvious security vulnerabilities introduced by this change. The new rules for embedme.top seem to be designed to block potentially unwanted scripts and popups, which could enhance security for users visiting that site.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant