Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add license information for filter lists #7

Open
antonok-edm opened this issue Jul 27, 2020 · 2 comments
Open

Add license information for filter lists #7

antonok-edm opened this issue Jul 27, 2020 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@antonok-edm
Copy link
Collaborator

Storing a license field along with each of the filter list entries will allow us to easily confirm that we are allowed to ship all of the adblock lists, and will allow license information to be automatically updated in brave://adblock, preventing the two from falling out of sync with each other.

A corresponding check could be added to verify.js to ensure the field is present on all entries, and specifies a compatible license.

@antonok-edm antonok-edm added the enhancement New feature or request label Jul 27, 2020
@antonok-edm antonok-edm self-assigned this Jul 27, 2020
@MasterKia
Copy link

@fmarier
Copy link
Member

fmarier commented Mar 28, 2023

Once this is generated automatically and shipped with the component, we can link to it from src/brave/components/third_paty/adblock/README.chromium (which gets pulled into brave://credits) and stop manually generating the LICENSE file from a manual copy of the metadata.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants