Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Android] Add "refresh status" feature in Brave Rewards dropdown tipping panel #10005

Closed
Miyayes opened this issue May 29, 2020 · 7 comments · Fixed by brave/brave-core#6301
Closed

[Android] Add "refresh status" feature in Brave Rewards dropdown tipping panel #10005

Miyayes opened this issue May 29, 2020 · 7 comments · Fixed by brave/brave-core#6301
Assignees
@samartnik
Labels
feature/rewards feature-request OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA Pass - Android Tab QA/Test-Plan-Specified QA/Yes release-notes/include
Milestone
1.13.x - Release #1

Comments

@Miyayes
Copy link
Collaborator

Miyayes commented May 29, 2020

Description

In order to reach feature parity with desktop and iOS, the "refresh status" feature (originally #3339) should be added to Android.

"Refresh status" is an important feature that enjoys widespread usage among users and creators. (See #3339 for more on initial motivations.)

@anthonypkeane @SergeyZhukovsky
@Miyayes Miyayes added the OS/Android Fixes related to Android browser functionality label May 29, 2020
@Miyayes
Copy link
Collaborator Author

Miyayes commented Jun 10, 2020

+1 https://www.reddit.com/r/BATProject/comments/h0c9e9/refresh_verified_publishercreator_status_on/

@Jonnyauk
Copy link

+1 https://www.reddit.com/r/BATProject/comments/h0c9e9/refresh_verified_publishercreator_status_on/

I’m the OP - without a refresh option it seems to have cached the non verified status across a couple of websites on my tablet running Android Brave v1.9.79. I have cleared caches, no effect.

On iOS and OSX desktop (latest current releases) I clicked refresh and it’s updated the status correctly. It’s been around 5 days and still not kicked in on that Android tablet ;(

@NejcZdovc
Copy link
Contributor

@Jonnyauk we cache the list for 7 days on mobile devices and 3 days on desktop

@samartnik samartnik assigned samartnik and unassigned deeppandya Jul 30, 2020
@samartnik samartnik mentioned this issue Jul 31, 2020
Merged
32 tasks
@samartnik
Copy link
Contributor

samartnik commented Jul 31, 2020 •
edited
Loading

Test plan:

  1. Switch on staging server.
  2. Go to wikipedia.org, make sure it's not verified.
  3. Click Refresh Status button, make sure it becomes verified.
  4. Export rewards database.
  5. In database change status in server_publisher_info table for wikipedia.org to 0.
  6. Import changed database.
  7. Recheck steps 2 and 3.

@samartnik
Copy link
Contributor

samartnik commented Jul 31, 2020 •
edited
Loading

Sample how it looks now:

device-2020-07-31-165017

@srirambv srirambv mentioned this issue Aug 17, 2020
Closed
@srirambv
Copy link
Contributor

+1 from @Occhioverde via #11241

@srirambv
Copy link
Contributor

Verification passed on OnePlus 6T with Android 10 running 1.13.81 x64 build

Verification passed on OnePlus 6T with Android 10 running 1.13.81 x64 build

This was referenced Sep 4, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@samartnik samartnik

Labels
feature/rewards feature-request OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA Pass - Android Tab QA/Test-Plan-Specified QA/Yes release-notes/include
Projects
None yet
Milestone
1.13.x - Release #1
Development

Successfully merging a pull request may close this issue.

[Android] Added ability to refresh publisher status brave/brave-core
7 participants
@Jonnyauk @kjozwiak @deeppandya @NejcZdovc @Miyayes @srirambv @samartnik