Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Desktop] Enabling Brave Rewards widget via settings page doesn't enable it in NTP #10067

Closed
srirambv opened this issue Jun 3, 2020 · 6 comments · Fixed by brave/brave-core#5982

Comments

@srirambv
Copy link
Contributor

srirambv commented Jun 3, 2020

Description

Enabling Brave Rewards widget via settings page doesn't enable it in NTP

Steps to Reproduce

  1. Clean install 1.10.81
  2. Disable rewards and binance widget from dashboard
  3. Close browser and relaunch
  4. Enable rewards widget from brave://settings/newtab
  5. Open a new tab no rewards widget is shown, dashboard shows enabled

Actual result:

Widget-Stack

Expected result:

Enabling widget from settings should be enabled on NTP

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.10.81 Chromium: 81.0.4044.138 (Official Build) beta (64-bit)
Revision 8c6c7ba89cc9453625af54f11fd83179e23450fa-refs/branch-heads/4044@{#999}
OS Linux

Version/Channel Information:

  • Can you reproduce this issue with the current release? N/A
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the dev channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

Found while testing #9584
Reproduces on all platforms

@rebron rebron added the priority/P3 The next thing for us to work on. It'll ride the trains. label Jun 9, 2020
ryanml added a commit to brave/brave-core that referenced this issue Jun 30, 2020
@LaurenWags
Copy link
Member

LaurenWags commented Jul 2, 2020

Ran into this today - noticed that if I have a NTP open when enabling one of the widgets from brave://settings, then the widget displays on the NTP. However, as with @srirambv steps if I don't have a NTP open when enabling widget from brave://settings, then the widget does not get displayed.

Reproduces for Binance widget as well as Rewards widget.

Reproduced with

Brave 1.10.97 Chromium: 83.0.4103.116 (Official Build) (64-bit)
Revision 8f0c18b4dca9b6699eb629be0f51810c24fb6428-refs/branch-heads/4103@{#716}
OS macOS Version 10.14.6 (Build 18G3020)
Brave 1.11.85 Chromium: 83.0.4103.116 (Official Build) dev (64-bit)
Revision 8f0c18b4dca9b6699eb629be0f51810c24fb6428-refs/branch-heads/4103@{#716}
OS macOS Version 10.14.6 (Build 18G3020)

@LaurenWags
Copy link
Member

@ryanml this issue doesn't have a milestone - which one should it be in?

@GeetaSarvadnya
Copy link

Reproduced in Windows 10 x64 - 1.11.97

@ryanml ryanml added this to the 1.12.x - Beta milestone Jul 16, 2020
@ryanml
Copy link
Contributor

ryanml commented Jul 16, 2020

@LaurenWags apologies - this is in 1.12 cc: @GeetaSarvadnya

@LaurenWags
Copy link
Member

awesome, thanks @ryanml 👍

@rebron rebron changed the title Enabling Brave Rewards widget via settings page doesn't enable it in NTP [Desktop] Enabling Brave Rewards widget via settings page doesn't enable it in NTP Jul 21, 2020
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Jul 22, 2020

Verification passed on


Brave | 1.12.94 Chromium: 84.0.4147.89 (Official Build) dev (64-bit)
-- | --
Revision | 19abfe7bcba9318a0b2a6bc6634a67fc834aa592-refs/branch-heads/4147@{#852}
OS | Windows 10 OS Version 1903 (Build 18362.959)

  • Verified STR from the description

Verification passed on

Brave 1.12.102 Chromium: 84.0.4147.89 (Official Build) dev (64-bit)
Revision 19abfe7bcba9318a0b2a6bc6634a67fc834aa592-refs/branch-heads/4147@{#852}
OS Ubuntu 18.04 LTS

Verified test plan from the description


Verified passed with

Brave | 1.12.108 Chromium: 84.0.4147.105 (Official Build) (64-bit)
-- | --
Revision | a6b12dfad6663f13a7e16e9a42a6a4975374096b-refs/branch-heads/4147@{#943}
OS | macOS Version 10.14.6 (Build 18G3020)

Verified STR from description

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants