Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Desktop] Fix safe-browsing URL replacement tests #10351

Closed
jumde opened this issue Jun 18, 2020 · 1 comment · Fixed by brave/brave-core#5887
Closed

[Desktop] Fix safe-browsing URL replacement tests #10351

jumde opened this issue Jun 18, 2020 · 1 comment · Fixed by brave/brave-core#5887

Comments

@jumde
Copy link
Contributor

jumde commented Jun 18, 2020

Description

BraveStaticRedirectNetworkDelegateHelperTest.ModifySafeBrowsingURLV4 and BraveStaticRedirectNetworkDelegateHelperTest.ModifySafeBrowsingURLV5 are failing on x86.

16:43:46  Retrying 2 tests (retry #0)
16:43:48  [ RUN      ] BraveStaticRedirectNetworkDelegateHelperTest.ModifySafeBrowsingURLV4
16:43:48  
16:43:48  ../../brave/browser/net/brave_static_redirect_network_delegate_helper_unittest.cc(194): error: Expected equality of these values:
16:43:48  
16:43:48    request_info->new_url_spec
16:43:48  
16:43:48      Which is: ""
16:43:48  
16:43:48    expected_url
16:43:48  
16:43:48      Which is: https://test.safebrowsing.com/v4/threatListUpdates:fetch?$req=ChkKCGNocm9taXVtEg02Ni
16:43:48  
16:43:48  Stack trace:
16:43:48  
16:43:48  Backtrace:
16:43:48  
16:43:48  	BraveStaticRedirectNetworkDelegateHelperTest_ModifySafeBrowsingURLV4_Test::TestBody [0x00092E8E+334] (C:\jenkins\x86-nightly\src\brave\browser\net\brave_static_redirect_network_delegate_helper_unittest.cc:194)
16:43:48  
16:43:48  
16:43:48  
16:43:48  [  FAILED  ] BraveStaticRedirectNetworkDelegateHelperTest.ModifySafeBrowsingURLV4 (2027 ms)
16:43:48  
16:43:48  [937/938] BraveStaticRedirectNetworkDelegateHelperTest.ModifySafeBrowsingURLV4 (2027 ms)
16:43:50  [ RUN      ] BraveStaticRedirectNetworkDelegateHelperTest.ModifySafeBrowsingURLV5
16:43:50  
16:43:50  ../../brave/browser/net/brave_static_redirect_network_delegate_helper_unittest.cc(210): error: Expected equality of these values:
16:43:50  
16:43:50    request_info->new_url_spec
16:43:50  
16:43:50      Which is: ""
16:43:50  
16:43:50    expected_url
16:43:50  
16:43:50      Which is: https://test.safebrowsing.com/v5/threatListUpdates:fetch?$req=ChkKCGNocm9taXVtEg02Ni
16:43:50  
16:43:50  Stack trace:
16:43:50  
16:43:50  Backtrace:
16:43:50  
16:43:50  	BraveStaticRedirectNetworkDelegateHelperTest_ModifySafeBrowsingURLV5_Test::TestBody [0x000931E2+334] (C:\jenkins\x86-nightly\src\brave\browser\net\brave_static_redirect_network_delegate_helper_unittest.cc:210)

Test Plan

Specified here: brave/brave-core#5887

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Jul 28, 2020

Verification is passed on


Brave | 1.12.102 Chromium: 84.0.4147.89 (Official Build) dev (64-bit)
-- | --
Revision | 19abfe7bcba9318a0b2a6bc6634a67fc834aa592-refs/branch-heads/4147@{#852}
OS | Windows 10 OS Version 1903 (Build 18362.959)


image

  • Ensured that files in /Safe Browsing is populated
  • Ensured that the websites warnings work as expected
    image

Verification passed on

Brave 1.12.104 Chromium: 84.0.4147.89 (Official Build) dev (64-bit)
Revision 19abfe7bcba9318a0b2a6bc6634a67fc834aa592-refs/branch-heads/4147@{#852}
OS Ubuntu 18.04 LTS

image

  • Verified that files in /Safe Browsing is populated
  • Verified that the websites warnings work as expected
    image

Verified passed with

Brave | 1.12.105 Chromium: 84.0.4147.105 (Official Build) (64-bit)
-- | --
Revision | a6b12dfad6663f13a7e16e9a42a6a4975374096b-refs/branch-heads/4147@{#943}
OS | macOS Version 10.14.6 (Build 18G3020)

Screen Shot 2020-07-31 at 10 45 23 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment