Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bookmark and/or history url match, offer setting #1048

Closed
rebron opened this issue Sep 9, 2018 · 0 comments
Closed

bookmark and/or history url match, offer setting #1048

rebron opened this issue Sep 9, 2018 · 0 comments
Labels
closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated. feature/url-bar

Comments

@rebron
Copy link
Collaborator

rebron commented Sep 9, 2018

Carrying over from brave/browser-laptop#13172

Description

Steps to Reproduce

  1. go to the browser settings
  2. from there go to the search tab
  3. in the search parameter section check only 'show bookmark matches'

Actual result:

When you make a search on the address bar you have no result.

Expected result:

since you have bookmarked some pages, you should be able to have some results when you start >searching from the address bar.

Reproduces how often:

Every time

Brave Version

about:brave info:

Brave 0.20.42
V8 6.4.388.41
rev 096c7cb
Muon 4.8.2
OS Release 4.4.0-109-generic
Update Channel Release
OS Architecture x64
OS Platform Linux
Node.js 7.9.0
Brave Sync v1.4.2
libchromiumcontent 64.0.3282.140

Additional Information

As a workaround, you have to check also "show history matches" but once you start searching from the address bar you have history macthes and bookmarks matches (which is normal btw).

Thank you for your help

@rebron rebron added this to the 2.x Backlog milestone Sep 9, 2018
@bbondy bbondy modified the milestones: 2.x Backlog, 1.x Backlog Sep 30, 2018
@rebron rebron modified the milestone: 1.x Backlog Feb 7, 2019
@bsclifton bsclifton added the closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated. label Mar 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated. feature/url-bar
Projects
None yet
Development

No branches or pull requests

3 participants