Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Android] Implement Desktop -> Android cross promotional Modal #10571

Closed
anthonypkeane opened this issue Jul 6, 2020 · 6 comments · Fixed by brave/brave-core#6171
Closed

[Android] Implement Desktop -> Android cross promotional Modal #10571

anthonypkeane opened this issue Jul 6, 2020 · 6 comments · Fixed by brave/brave-core#6171
Assignees
@deeppandya
Labels
design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include
Milestone
1.13.x - Release #1

Comments

@anthonypkeane
Copy link

anthonypkeane commented Jul 6, 2020 •
edited by karenkliu
Loading

Description

As part of the updated onboarding, please implement "Cross Promote Brave on Desktop"

On Day 12:
image
@anthonypkeane anthonypkeane added design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. QA/Yes OS/Android Fixes related to Android browser functionality labels Jul 6, 2020
@anthonypkeane
Copy link
Author

brave desktop callout

@karenkliu
Copy link

karenkliu commented Jul 20, 2020 •
edited
Loading

This has the updates from marketing:

image

@anthonypkeane
Copy link
Author

anthonypkeane commented Jul 20, 2020 •
edited
Loading

Copy proposal

Download Brave at brave.com on your laptop or tablet for a faster and more private web

@deeppandya deeppandya mentioned this issue Jul 22, 2020
Merged
32 tasks
@deeppandya deeppandya mentioned this issue Jul 26, 2020
Closed
@deeppandya deeppandya added this to the 1.13.x - Nightly milestone Jul 28, 2020
@anthonypkeane
Copy link
Author

Hey @karenkliu
@srirambv noted that having the brave.com text in a different colour makes it seem like brave.com is a URL which it isn't

Are you ok with @deeppandya keeping the brave.com colour the same black?

@karenkliu
Copy link

@anthonypkeane oh, I didn't realize that wasn't supposed to be a link. Sure - make it text colored

This was referenced Aug 21, 2020
Closed
Closed
Closed
@karenkliu karenkliu mentioned this issue Aug 27, 2020
Closed
@srirambv
Copy link
Contributor

srirambv commented Sep 2, 2020

Verification passed on OnePlus 6T with Android 10 running 1.13.83 x64 build

Verified cross-platform promotional modal is shown for a new user after 12 days of installation
English French
image image

Verification passed on Samsung Tab A with Android 10 running 1.13.83 x64 build

Verified cross-platform promotional modal is shown for a new user after 12 days of installation
English German
image image

This was referenced Sep 4, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@deeppandya deeppandya

Labels
design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include
Projects
None yet
Milestone
1.13.x - Release #1
Development

Successfully merging a pull request may close this issue.

Cross promotional modal dp brave/brave-core
4 participants
@karenkliu @deeppandya @anthonypkeane @srirambv