-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Desktop] WebGL Drawing FP blocking not working correctly when FP set to Strict #10675
Comments
Reproduced on:
|
Thanks all for documenting this! |
I've updated the test page text so that is clear that the farbling-style protections (different per-session, per-etld+1) should only hold in "standard" protections, and not "strict" (bc in strict we just block WebGL drawing all together, since its too difficult to randomize), and so blocking will look identical in all origins. Thanks @LaurenWags for reporting! |
i've labeled "not actionable" only bc there isn't a "it was pete's test fault, not Mark's code fault" option ;) |
Description
When testing on our QA test pages for FP farbling, I noticed that if FP is set to Strict, WebGL Drawing does not appear to be working correctly.
Per discussion with @pes10k logging this and tagging @pilgrim-brave to hopefully take a look.
Steps to Reproduce
Standard
in shieldsAllow All
in shieldsStrict
in shields10 Generate FPs.
Actual result:
WebGL Drawing is the same on both pages
Expected result:
Expected WebGL Drawing to be different on both pages (but the same across its row)
Reproduces how often:
easily
Brave version (brave://version info)
1.11.92
Version/Channel Information:
Other Additional Information:
Miscellaneous Information:
cc @rebron @brave/legacy_qa
The text was updated successfully, but these errors were encountered: