Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow up of #10737 - purchaseIntentSignalHistory is empty for some sites #10771

Closed
GeetaSarvadnya opened this issue Jul 16, 2020 · 2 comments
Closed
Assignees

Comments

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Jul 16, 2020

Description

Follow up of #10737
purchaseIntentSignalHistory is empty for some sites

Steps to Reproduce

  1. Set OS locale to Japan
  2. Launch brave in staging env
  3. Enable rewards and open https://fusafusaraifusutairu.blogspot.jp/ in a new tab
  4. Wait until page is loaded fully
  5. Open client.json and look for purchaseIntentSignalHistory
  6. purchaseIntentSignalHistory is empty

Actual result:

purchaseIntentSignalHistory is empty "purchaseIntentSignalHistory": {},

Sites for which purchase intent is empty
https://www.angfa.jp/
https://fusafusaraifusutairu.blogspot.jp/

Expected result:

purchaseIntentSignalHistory should not be empty

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.11.97 Chromium: 84.0.4147.89 (Official Build) (64-bit)
Revision 19abfe7bcba9318a0b2a6bc6634a67fc834aa592-refs/branch-heads/4147@{#852}
OS Windows 10 OS Version 1903 (Build 18362.959)

Version/Channel Information:

  • Can you reproduce this issue with the current release? NA
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the dev channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc @brave/legacy_qa @moritzhaller @jsecretan @rebron

Reproduced by @btlechowski

@tmancey tmancey changed the title [Desktop]Follow up of #10737 - purchaseIntentSignalHistory is empty for some sites Follow up of #10737 - purchaseIntentSignalHistory is empty for some sites Aug 5, 2020
@tmancey tmancey added OS/Android Fixes related to Android browser functionality bug and removed QA/Test-Plan-Specified QA/Yes labels Aug 5, 2020
@tmancey tmancey removed the OS/Android Fixes related to Android browser functionality label Aug 20, 2020
@srirambv srirambv changed the title Follow up of #10737 - purchaseIntentSignalHistory is empty for some sites [Desktop] Follow up of #10737 - purchaseIntentSignalHistory is empty for some sites Sep 9, 2020
@tmancey tmancey changed the title [Desktop] Follow up of #10737 - purchaseIntentSignalHistory is empty for some sites Follow up of #10737 - purchaseIntentSignalHistory is empty for some sites Dec 5, 2020
@tmancey tmancey added the QA/Yes label Feb 2, 2021
@tmancey tmancey added priority/P3 The next thing for us to work on. It'll ride the trains. release-notes/exclude labels Feb 2, 2021
@tmancey
Copy link
Contributor

tmancey commented Feb 2, 2021

@GeetaSarvadnya could you please retest. Thanks

@tmancey tmancey closed this as completed Feb 2, 2021
@tmancey tmancey added this to the 1.22.x - Nightly milestone Feb 4, 2021
@btlechowski btlechowski added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Mar 3, 2021
@btlechowski
Copy link

Verification passed on

Brave 1.22.53 Chromium: 89.0.4389.72 (Official Build) beta (64-bit)
Revision 3f345f156bfd157bd1bea06310e55f3fb2490359-refs/branch-heads/4389@{#1393}
OS Ubuntu 18.04 LTS

Verified test plan from description.

Verified purchase intent for https://www.angfa.jp/:

"purchaseIntentSignalHistory":{"ANGFA02":[{"timestamp_in_seconds":1615037356,"weight":1}]},"adsUUIDSeen":{"4983dc92-09fd-4e5c-94c3-616a4728c1d9":1}

It took a long time though, because the purchase intent is extracted when page is fully loaded (spinner stops spinning)

Failed to extract purchase intent for https://fusafusaraifusutairu.blogspot.jp/:
image
Logged as follow up: #14528

@btlechowski btlechowski added QA Pass-Linux and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Mar 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

3 participants