Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NTP Settings Design follow up #11103

Closed
ryanml opened this issue Aug 6, 2020 · 4 comments · Fixed by brave/brave-core#6351
Closed

NTP Settings Design follow up #11103

ryanml opened this issue Aug 6, 2020 · 4 comments · Fixed by brave/brave-core#6351

Comments

@ryanml
Copy link
Contributor

ryanml commented Aug 6, 2020

Related issue: #10318

Feedback should be implemented as described here: #10318 (comment) and here: brave/brave-core#6015 (comment)

@srirambv
Copy link
Contributor

Verification passed on

Brave 1.13.80 Chromium: 85.0.4183.69 (Official Build) dev (64-bit)
Revision 94abc2237ae0c9a4cb5f035431c8adfb94324633-refs/branch-heads/4183@{#1658}
OS Linux
  • Verified focus ring is using the correct colour when clicked or focused by the keyboard tab
Light Dark
image image
With overlay (Light) Without overlay (Light)
image image
With overlay (Dark) Without Overlay (Dark)
image image
  • Verified description is using Poppins font but set at 13px (known issue) instead of 17px as per spec
  • Verified bottom margin is also removed
Light Dark
image image
  • Verified content area is of width 360px(known issues) instead of 390px as per sepc
Light Dark
image image
Add card Background card 2 Background card 1
image image image

@srirambv
Copy link
Contributor

Verification passed on

Brave 1.13.80 Chromium: 85.0.4183.83 (Official Build) (64-bit)
Revision 94abc2237ae0c9a4cb5f035431c8adfb94324633-refs/branch-heads/4183@{#1658}
OS Windows 10 OS Version 1809 (Build 17763.1397)
  • Verified focus ring is using the correct colour when clicked or focused by the keyboard tab
Light Dark
Screenshot 2020-08-26 at 11 29 42 a m Screenshot 2020-08-26 at 11 38 06 a m

Screenshot 2020-08-26 at 11 31 43 a m

  • Verified clicking outside the dashboard closes the dashboard setting
With overlay (Light) Without overlay (Light)
Screenshot 2020-08-26 at 11 29 42 a m Screenshot 2020-08-26 at 11 40 29 a m
With overlay (Dark) Without Overlay (Dark)
Screenshot 2020-08-26 at 11 30 57 a m Screenshot 2020-08-26 at 11 31 59 a m
  • Verified description is using Poppins font but set at 13px (known issue) instead of 17px as per spec
  • Verified bottom margin is also removed
Light Dark
Screenshot 2020-08-26 at 11 32 42 a m Screenshot 2020-08-26 at 11 33 12 a m
  • Verified content area is of width 360px(known issues) instead of 390px as per sepc
Light Dark
Screenshot 2020-08-26 at 11 33 43 a m Screenshot 2020-08-26 at 11 33 29 a m
Add card Background card 2 Background card 1
Screenshot 2020-08-26 at 11 34 04 a m Screenshot 2020-08-26 at 11 34 21 a m Screenshot 2020-08-26 at 11 34 47 a m

@srirambv
Copy link
Contributor

Verification passed on

Brave 1.13.80 Chromium: 85.0.4183.83 (Official Build) (64-bit)
Revision 94abc2237ae0c9a4cb5f035431c8adfb94324633-refs/branch-heads/4183@{#1658}
OS Windows 10 OS Version 1809 (Build 17763.1397)
  • Verified focus ring is using the correct colour when clicked or focused by the keyboard tab
Light Dark
Screenshot 2020-08-26 at 11 47 17 a m Screenshot 2020-08-26 at 11 47 00 a m

Screenshot 2020-08-26 at 11 47 43 a m

  • Verified clicking outside the dashboard closes the dashboard setting
With overlay (Light) Without overlay (Light)
Screenshot 2020-08-26 at 11 47 17 a m Screenshot 2020-08-26 at 11 48 02 a m
With overlay (Dark) Without Overlay (Dark)
Screenshot 2020-08-26 at 11 47 00 a m Screenshot 2020-08-26 at 11 48 20 a m
  • Verified description is using Poppins font but set at 13px (known issue) instead of 17px as per spec
  • Verified bottom margin is also removed
Light Dark
Screenshot 2020-08-26 at 11 49 27 a m Screenshot 2020-08-26 at 11 49 35 a m
  • Verified content area is of width 360px(known issues) instead of 390px as per sepc
Light Dark
Screenshot 2020-08-26 at 11 49 57 a m Screenshot 2020-08-26 at 11 49 46 a m
Add card Background card 2 Background card 1
Screenshot 2020-08-26 at 11 50 10 a m Screenshot 2020-08-26 at 11 50 27 a m Screenshot 2020-08-26 at 11 50 35 a m

@srirambv
Copy link
Contributor

Follow up issue #11441

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment