Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pixel artifacts on web and browser elements #1128

Closed
cndouglas opened this issue Sep 14, 2018 · 4 comments
Closed

Pixel artifacts on web and browser elements #1128

cndouglas opened this issue Sep 14, 2018 · 4 comments

Comments

@cndouglas
Copy link
Contributor

Description

If you look at certain web elements and UI elements, there are random white or black pixels drawn on the elements. This problem is found on macOS 10.13.6. This problem is found on a fresh profile. Seems like it started happening a few days ago (Brave 0.55.3 or Chromium 70.0.3538.12 maybe).

Steps to Reproduce

  1. Go to any website.
  2. Click the Brave shields button.

Actual result:

There are random white pixels on the UI switches:
image

Expected result:

There should not be any random white pixels.

Reproduces how often:

Almost all the time.

Brave version (chrome://version info)

Brave | 0.55.3 Chromium: 70.0.3538.12 (Official Build) dev (64-bit)
Revision | ad61584ca32115f953ce656dd75b44f1c502a75d-refs/branch-heads/3538@{#179}
OS | Mac OS X
JavaScript | V8 7.0.276.6
Flash | (Disabled)
User Agent | Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/70.0.3538.12 Safari/537.36

Reproducible on current release:

I haven't tried.

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields? No.
  • Is the issue reproducible on the latest version of Chrome? I haven't tried.

Additional Information

More examples:
Search field and GitHub issue tags:

GitHub issue tags:

Text field selected text:

@srirambv srirambv added needs-investigation A bug not 100% confirmed/fixed OS/macOS labels Sep 14, 2018
@srirambv srirambv added this to the 1.x Backlog milestone Sep 14, 2018
@cndouglas
Copy link
Contributor Author

Thanks to #1160 (comment) by @kevinschaich for finding the root problem: turning off hardware acceleration also resolves this issue.

@cndouglas
Copy link
Contributor Author

Fixed with brave/brave-core#531

@bsclifton bsclifton modified the milestones: 1.x Backlog, Releasable builds 0.55.x Oct 3, 2018
@bsclifton
Copy link
Member

Updated milestone since this was fixed with above PR (which landed in 0.55.x) 😄

@kjozwiak
Copy link
Member

kjozwiak commented Oct 11, 2018

Went through verification using the following build under macOS 10.13.6 x64 - PASSED

Brave 0.55.12 Chromium: 70.0.3538.45 (Official Build) beta(64-bit)
Revision cbdc32e4334458954e9def214d7e5fa1ca1960eb-refs/branch-heads/3538@{#830}
OS Mac OS X
  • Ensured that HW Acceleration was still enabled by default
  • Visited about a dozen websites and clicked on the shield, ensured there's no pixel artifacts
  • Searched a large list of GH issues and didn't see any pixel artifacts
  • Edited several GH issues and didn't see any pixel artifacts in the edit box

@LaurenWags when you have some time, could you go through a quick check and make sure you're not seeing the pixel artifacts anymore? Once you do a quick check, you can label it as QA Pass-macOS.

Verified passed with macOS 10.12.6 x64 - Passed

Brave 0.55.12 Chromium: 70.0.3538.45 (Official Build) beta(64-bit)
Revision cbdc32e4334458954e9def214d7e5fa1ca1960eb-refs/branch-heads/3538@{#830}
OS Mac OS X
  • Ensured that HW Acceleration was still enabled by default
  • Visited about a dozen websites and clicked on the shield, ensured there's no pixel artifacts
  • Searched a large list of GH issues and didn't see any pixel artifacts
  • Edited several GH issues and didn't see any pixel artifacts in the edit box

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants