[Desktop] user funds do not move to Uphold - follow up to 8428 #11298

LaurenWags · 2020-08-18T14:45:57Z

Description

Follow up to #8428 and brave/brave-core#6000

If you have anon user funds and you connect a KYC'd uphold wallet, the user funds do not move to Uphold.

Steps to Reproduce

Test plan 4 from brave/brave-core#6000

enable rewards
restore wallet with user funds
connect kyc uphold account
make sure that funds are transferred

Actual result:

Funds not moved. See below in the logs.

[ RESPONSE - OnTransferFunds ]
> Url: https://grant.rewards.bravesoftware.com/v3/wallet/uphold/redacted/claim
> Result: Failure
> HTTP Code: 403
> Body: {"message":"error linking wallet: failed to verify transaction: failed to verify transaction","code":403}

Expected result:

funds should move

Reproduces how often:

easily

Brave version (brave://version info)

Brave	1.13.76 Chromium: 85.0.4183.69 (Official Build) dev (64-bit)
Revision	4554ea1a1171bd8d06951a4b7d9336afe6c59967-refs/branch-heads/4183@{#1426}
OS	macOS Version 10.14.6 (Build 18G3020)

Version/Channel Information:

Can you reproduce this issue with the current release? n/a
Can you reproduce this issue with the beta channel? yes
Can you reproduce this issue with the nightly channel? yes

Other Additional Information:

Does the issue resolve itself when disabling Brave Shields?
Does the issue resolve itself when disabling Brave Rewards?
Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc @NejcZdovc @rebron @brave/legacy_qa

The text was updated successfully, but these errors were encountered:

LaurenWags · 2020-08-18T14:46:43Z

I did not add OS/Android label as Android didn't have the ability for users to add their own funds. Please add label if this needs to be checked there as well. cc @srirambv

Resolves brave/brave-browser#11298

GeetaSarvadnya · 2020-08-20T06:46:30Z

Reproduced in Windows 10 x64 - 1.13.x Verified that ad grants are not moved to KYC'd uphold wallet

LaurenWags · 2020-08-24T20:38:33Z

uplift approved, waiting on new 1.13.x build to test

GeetaSarvadnya · 2020-08-26T16:46:47Z

Verification is passed on


Brave | 1.13.80 Chromium: 85.0.4183.83 (Official Build) (64-bit)
-- | --
Revision | 94abc2237ae0c9a4cb5f035431c8adfb94324633-refs/branch-heads/4183@{#1658}
OS | Windows 10 OS Version 1903 (Build 18362.1016)

Scenario 1: - PASSED

Verified the STR from the description
Restored a wallet with user funds
Verified wallet status is Not connected and Deposited balance is shown correctly in brave://rewards-internals
Connected KYC'd uphold wallet and confirm funds are transferred to uphold card
Confirmed seeing the below in logs

[ REQUEST ]
> URL: https://grant.rewards.bravesoftware.com/v3/wallet/uphold/redacted/claim
> Method: UrlMethod::POST
> Content: ..

[ RESPONSE - OnTransferFunds ]
> Url: https://grant.rewards.bravesoftware.com/v3/wallet/uphold/redacted/claim
> Result: Success
> HTTP Code: 200

Scenario 2 - make sure that claim works with user funds and VG - PASSED

Clean profile, enable rewards. Restore a wallet with user funds and an Ad grant. Claim Ad grant
Ensured deposited BAT (5 BAT) and Rewards BAT (ad grants 20 BAT) is shown correctly in brave://rewards-internals
Connect KYC'd user wallet. Confirmed seeing the below in my logs:

[ REQUEST ]
> URL: https://grant.rewards.bravesoftware.com/v3/wallet/uphold/4.../claim
> Method: UrlMethod::POST

[ RESPONSE - OnTransferFunds ]
> Url: https://grant.rewards.bravesoftware.com/v3/wallet/uphold/4.../claim
> Result: Success
> HTTP Code: 200

[ REQUEST ]
> URL: https://grant.rewards.bravesoftware.com/v1/suggestions/claim
> Method: UrlMethod::POST

[ RESPONSE - OnRedeemTokens ]
> Url: https://grant.rewards.bravesoftware.com/v1/suggestions/claim
> Result: Success
> HTTP Code: 200

Confirmed all BAT (user funded and Ad grant) moved to Uphold:

Scenario 3 - make sure that claim works with 0 balance - PASSED

Clean profile, enable rewards wallet balance is 0 BAT and wallet status is Not Connected
Connect KYC'd user wallet. Confirmed seeing the below in my logs:

[ REQUEST ]
> URL: https://grant.rewards.bravesoftware.com/v3/wallet/uphold/1.../claim
> Method: UrlMethod::POST

[ RESPONSE - OnTransferFunds ]                                                                                                                                                               > Url: https://grant.rewards.bravesoftware.com/v3/wallet/uphold/1.../claim           
> Result: Success                                                                                                                                                                            
> HTTP Code: 200

Verification PASSED on macOS 10.15.6 x64 using the following build:

Brave | 1.13.80 Chromium: 85.0.4183.83 (Official Build) (64-bit)
-- | --
Revision | 94abc2237ae0c9a4cb5f035431c8adfb94324633-refs/branch-heads/4183@{#1658}
OS | macOS Version 10.15.6 (Build 19G73)

Test Plan 1:

Checked Preferences and ensured that that the payment_id and seed values were populated via brave.rewards.wallet.

Test Plan 2:

ensured that you can restore several wallets using the Restore feature under Manage Your Wallet

Test Plan 3:

Test Plan 4 - Scenario 1 (user funds):

Created & Restored a wallet that had user funds (10 BAT in this case). Example:

User Funded Wallet	User Funded Wallet

Connected to a KYC'd account and ensured the following:

[ REQUEST ]
> URL: https://grant.rewards.bravesoftware.com/v3/wallet/uphold/[2a............]/claim
> Method: UrlMethod::POST
> Content:......

[ RESPONSE - OnTransferFunds ]
> Url: https://grant.rewards.bravesoftware.com/v3/wallet/uphold/[2a............]/claim
> Result: Success
> HTTP Code: 200

Test Plan 4 - Scenario 1 (user funds + VG):

Created & Restored a wallet that had user funds (10 BAT in this case) and claimed a VG. Example:

User Funded Wallet	User Funded Wallet

Connected to a KYC'd account and ensured the following:

[ REQUEST ]
> URL: https://grant.rewards.bravesoftware.com/v3/wallet/uphold/[14.................]/claim
> Method: UrlMethod::POST
> Content:........

[ RESPONSE - OnTransferFunds ]
> Url: https://grant.rewards.bravesoftware.com/v3/wallet/uphold/[14.................]/claim
> Result: Success
> HTTP Code: 200

[ REQUEST ]
> URL: https://grant.rewards.bravesoftware.com/v1/suggestions/claim
> Method: UrlMethod::POST

[ RESPONSE - OnRedeemTokens ]
> Url: https://grant.rewards.bravesoftware.com/v1/suggestions/claim
> Result: Success
> HTTP Code: 200

Verification passed on

Brave	1.13.80 Chromium: 85.0.4183.83 (Official Build) (64-bit)
Revision	94abc2237ae0c9a4cb5f035431c8adfb94324633-refs/branch-heads/4183@{#1658}
OS	Ubuntu 18.04 LTS

Verified test plan from brave/brave-core#6000

Test Plan 1:

Checked Preferences and ensured that that the payment_id and seed values were populated via brave.rewards.wallet.

Test Plan 2:

ensured that you can restore several wallets using the Restore feature under Manage Your Wallet

Test Plan 3:

Test Plan 4 - Scenario 1 (user funds):

Created & Restored a wallet that had user funds. Example:

Connected to a KYC'd account and ensured the following:

[ RESPONSE - OnTransferFunds ]
> Url: https://grant.rewards.bravesoftware.com/v3/wallet/uphold/[redacted]/claim
> Result: Success
> HTTP Code: 200

Test Plan 4 - Scenario 2 (user funds + VG):

Created & Restored a wallet that had user funds and claimed a VG. Example:

Connected to a KYC'd account and ensured the following:

[ RESPONSE - OnTransferFunds ]
> Url: https://grant.rewards.bravesoftware.com/v3/wallet/uphold/[redacted]/claim
> Result: Success
> HTTP Code: 200

[ RESPONSE - OnRedeemTokens ]
> Url: https://grant.rewards.bravesoftware.com/v1/suggestions/claim
> Result: Success
> HTTP Code: 200

LaurenWags · 2020-08-26T17:44:40Z

Additional scenario verified (not listed in test plan from PR) using

Brave | 1.13.80 Chromium: 85.0.4183.83 (Official Build) (64-bit)
-- | --
Revision | 94abc2237ae0c9a4cb5f035431c8adfb94324633-refs/branch-heads/4183@{#1658}
OS | macOS Version 10.14.6 (Build 18G3020)

Confirmed claim process including getting KYC'd with Uphold.

Claim an Ad grant on staging env:

Click Verify Wallet, follow prompts and provide all expected data to Uphold
Contacted Uphold to get KYC completed
Confirmed browser got KYC notice:

Confirmed Ad grant moved to Uphold account:

[ REQUEST ]
> URL: https://grant.rewards.bravesoftware.com/v3/wallet/uphold/........./claim
> Method: UrlMethod::POST
> Content: ........
[10503:775:0826/132157.823391:VERBOSE6:wallet_claim.cc(163)] 
[ RESPONSE - OnTransferFunds ]
> Url: https://grant.rewards.bravesoftware.com/v3/wallet/uphold/........./claim
> Result: Success
> HTTP Code: 200
> Body: null

[ REQUEST ]
> URL: https://grant.rewards.bravesoftware.com/v1/suggestions/claim
> Method: UrlMethod::POST
> Content: .........
[ RESPONSE - OnRedeemTokens ]
> Url: https://grant.rewards.bravesoftware.com/v1/suggestions/claim
> Result: Success
> HTTP Code: 200
> Body:

LaurenWags added feature/rewards priority/P2 A bad problem. We might uplift this to the next planned release. QA/Yes release-notes/exclude OS/Desktop labels Aug 18, 2020

NejcZdovc self-assigned this Aug 18, 2020

NejcZdovc added this to the 1.13.x - Beta milestone Aug 18, 2020

NejcZdovc added the QA/Blocked label Aug 18, 2020

NejcZdovc mentioned this issue Aug 18, 2020

Fixes user funds claim brave/brave-core#6442

Merged

32 tasks

NejcZdovc added a commit to brave/brave-core that referenced this issue Aug 18, 2020

Fixes user funds claim

a5bdc84

Resolves brave/brave-browser#11298

LaurenWags mentioned this issue Aug 18, 2020

Implement new persona creation #8428

Closed

NejcZdovc closed this as completed in brave/brave-core#6442 Aug 18, 2020

NejcZdovc added a commit to brave/brave-core that referenced this issue Aug 19, 2020

Fixes user funds claim

816a3e3

Resolves brave/brave-browser#11298

NejcZdovc mentioned this issue Aug 19, 2020

Fixes user funds claim (uplift to 1.13.x) brave/brave-core#6453

Merged

4 tasks

GeetaSarvadnya mentioned this issue Aug 21, 2020

Audit server responses #9666

Closed

This was referenced Aug 21, 2020

Manual test run on OS X for 1.13.x - Release #11375

Closed

Manual test run on Windows x64 for 1.13.x - Release #11376

Closed

Manual test run on Linux for 1.13.x - Release #11377

Closed

NejcZdovc removed the QA/Blocked label Aug 25, 2020

GeetaSarvadnya added the QA Pass-Win64 label Aug 26, 2020

rebron mentioned this issue Aug 26, 2020

[Desktop] Add Gemini widget to new tab page #11457

Closed

kjozwiak added the QA Pass-macOS label Aug 27, 2020

btlechowski added the QA Pass-Linux label Aug 27, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Desktop] user funds do not move to Uphold - follow up to 8428 #11298

[Desktop] user funds do not move to Uphold - follow up to 8428 #11298

LaurenWags commented Aug 18, 2020

LaurenWags commented Aug 18, 2020

GeetaSarvadnya commented Aug 20, 2020

LaurenWags commented Aug 24, 2020

GeetaSarvadnya commented Aug 26, 2020 •

edited by btlechowski

Loading

LaurenWags commented Aug 26, 2020

[Desktop] user funds do not move to Uphold - follow up to 8428 #11298

[Desktop] user funds do not move to Uphold - follow up to 8428 #11298

Comments

LaurenWags commented Aug 18, 2020

Description

Steps to Reproduce

Actual result:

Expected result:

Reproduces how often:

Brave version (brave://version info)

Version/Channel Information:

Other Additional Information:

Miscellaneous Information:

LaurenWags commented Aug 18, 2020

GeetaSarvadnya commented Aug 20, 2020

LaurenWags commented Aug 24, 2020

GeetaSarvadnya commented Aug 26, 2020 • edited by btlechowski Loading

LaurenWags commented Aug 26, 2020

GeetaSarvadnya commented Aug 26, 2020 •

edited by btlechowski

Loading