Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Sample ad doesn't open landing page when rewards is enabled #11323

Closed
srirambv opened this issue Aug 19, 2020 · 7 comments
Closed

[Android] Sample ad doesn't open landing page when rewards is enabled #11323

srirambv opened this issue Aug 19, 2020 · 7 comments

Comments

@srirambv
Copy link
Contributor

Description

Sample ad doesn't open landing page when rewards is enabled

Steps to reproduce

  1. Clean install nightly
  2. Enable rewards via onboarding/rewards page
  3. Finish onboarding and click on sample ad notification, doesn't load the landing page

Actual result

sampleads

Expected result

Should load landing page

Issue reproduces how often

Easy

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? NA
  • Can you reproduce this issue with the current Play Store Beta version? NA
  • Can you reproduce this issue with the current Play Store Nightly version? Yes

Device details

  • Install type (ARM, x86): ARM
  • Device type (Phone, Tablet, Phablet): Phone
  • Android version: 10

Brave version

1.14.44

Website problems only

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Additional information

@tmancey
Copy link
Contributor

tmancey commented Aug 20, 2020

@SergeyZhukovsky Sample ad does not use ads lib, passing over to Android team sir

@SergeyZhukovsky
Copy link
Member

@srirambv that's correct. We open a panel on the sample ad notification click. cc @deeppandya. Closing it.

@srirambv
Copy link
Contributor Author

srirambv commented Aug 21, 2020

@SergeyZhukovsky do we still need to retain the text as tap to learn more? Opening rewards panel isn't learning more and also iOS is loading https://brave.com/my-first-ad link
image

@SergeyZhukovsky
Copy link
Member

@srirambv it looks like that, cc @anthonypkeane to confirm

@anthonypkeane
Copy link

Yes, please keep the text as-is.

@srirambv
Copy link
Contributor Author

This doesn't seem fixed on 1.13.x channel. I can still see it loads the my-fist-ad page when clicking on the sample notification
sampleadnotification

@srirambv
Copy link
Contributor Author

srirambv commented Sep 2, 2020

Verification passed on OnePlus 6T with Android 10 running 1.13.83 x64 build

  • Verified clicking on ad notification opens rewards panel

Verification passed on Samsung Tab A with Android 10 running 1.13.83 x64 build

  • Verified clicking on ad notification opens rewards panel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants