Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redundant rewards setting to address user confusion #11467

Closed
30 tasks done
NejcZdovc opened this issue Aug 27, 2020 · 3 comments · Fixed by brave/brave-core#6680
Closed
30 tasks done

Remove redundant rewards setting to address user confusion #11467

NejcZdovc opened this issue Aug 27, 2020 · 3 comments · Fixed by brave/brave-core#6680
Assignees
@deeppandya @NejcZdovc
Labels
feature/rewards OS/Android Fixes related to Android browser functionality OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA Pass - Android Tab QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.18.x - Release

Comments

@NejcZdovc
Copy link
Contributor

NejcZdovc commented Aug 27, 2020 •
edited by deeppandya
Loading

Desktop

  • remove main switch on rewards page
  • remove enable rewards in panel
  • remove enable rewards in NTP
  • remove join rewards on rewards page
  • remove join rewards in panel
  • remove join rewards in NTP
  • remove all checks for rewards enabled
  • change hide bat logo text so that is not dependent on enabled
  • check for wallet references in rewards_service.h, ledger.h, ledger_client.h and remove all that is not used anymore
  • remove all unused translations (locals)
  • implement new wallet creation
    • promotion flow
    • enabling ads
    • external wallet
  • implement new process handling
    • panel
    • rewards page
    • internals page
    • tipping banner
    • based on ads/ac settings
  • add migration for rewards flag for ac and ads
  • implement new onboarding on welcome screen
  • remove ads onboarding for new regions
  • adjust browser tests to new logic
  • implement new UI on rewards page

Android

  • remove join rewards on rewards page
  • remove disabled state from the panel
  • remove join rewards from the panel
  • implement new onboarding
  • remove join rewards on NTP
@NejcZdovc NejcZdovc mentioned this issue Aug 27, 2020
Closed
15 tasks
@NejcZdovc NejcZdovc added the OS/Android Fixes related to Android browser functionality label Sep 9, 2020
@bsclifton bsclifton changed the title [Desktop] Remove rewards switch Remove rewards switch Sep 9, 2020
@anthonypkeane anthonypkeane added the priority/P3 The next thing for us to work on. It'll ride the trains. label Sep 9, 2020
@NejcZdovc NejcZdovc mentioned this issue Sep 22, 2020
Merged
32 tasks
@NejcZdovc NejcZdovc self-assigned this Sep 22, 2020
@NejcZdovc NejcZdovc added priority/P2 A bad problem. We might uplift this to the next planned release. and removed priority/P3 The next thing for us to work on. It'll ride the trains. labels Sep 28, 2020
@deeppandya
Copy link

@NejcZdovc Do we still need to Reset Brave rewards in Brave Rewards section and Hide Brave Rewards icon in Appearance section ? i think we should remove it as we won't have any switch to disable brave rewards for BRE.

@NejcZdovc
Copy link
Contributor Author

we still need reset so that you can reset rewards (remove wallet, db, etc). We also need hide icon, but should not be tied to enabled anymore. We will keep it on desktop as well

@deeppandya deeppandya mentioned this issue Oct 21, 2020
Closed
33 tasks
@NejcZdovc NejcZdovc added this to the 1.18.x - Nightly milestone Oct 22, 2020
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Nov 24, 2020 •
edited by btlechowski
Loading

Verification passed on


Brave | 1.18.59 Chromium: 87.0.4280.67 (Official Build) dev (64-bit)
-- | --
Revision | 0e5d92df40086cf0050c00f87b11da1b14580930-refs/branch-heads/4280@{#1441}
OS | Windows 10 OS Version 2004 (Build 19041.630)
Plan 1: Verify Join Rewards switch removal from brave://rewards page

image

Plan 2 & 3: Verify claim grants and Tips
  • Ensured grants can be claimed from BR panel, able to see claimed grants in wallet balance in brave://rewards page
    image
  • Ensured claim rewards option is removed from NTP and rewards settings page once grants is claimed from BR panel.
  • Ensured able to tip verified and non verified pubs (GH/Reddit/Generic websites/YT/Twitch/Twitter/Vimeo)

Monthly tips
image

One time Tips:
image

Plan 4. Verify disable rewards in `1.17.x` and then upgrade to `1.18.x`

Diable Brave Rewards switch in 1.17.x
image

Upgrade to 1.18.x
image

  • Ensured that Auto-Contribute and Ads switches are OFF after upgrade to 1.18.x
  • Ensured that rewards onboarding popup is shown after upgrade to 1.18.x
  • Ensured rewards and ads settings are retained after upgrade to 1.18.x
Plan 4.1 Verify disable Ads and AC in `1.17.x` and then upgrade to `1.18.x` - Ensured that Brave Rewards switch is removed from 1.18.x in brave://rewrads after upgrade - Ensured Ads and AC switches are OFF after upgrade to 1.18.x - Ensured that rewards onboarding popup is not shown in 1.18.x
Plan 4.2 Perform AC and disable rewards in `1.17.x` and then upgrade to `1.18.x`

1.17.x
image

1.17.x
image

After upgrade to 1.18.x
Ensured Brave Rewards switch is removed after upgrade to 1.18.x
Ensured BR panel transactions are not lost after upgrade 1.18.x
Ensured rewards onboarding popup is shown after upgrade to 1.18.x
Ensured Tips data is retained in Monthly Contributions and Tips panel
Ensured AC and wallet balance Tips values are shown correctly in the monthly statement in 1.18.x
Ensured AC and wallet balance Tips values are shown correctly in the brave://rewards-internals in 1.18.x
image
image
image

Plan 5: Verify rewards extension, ledger or ads process
  • Ensured there is no rewards extension, ledger, or ads process in a clean profile
    image
Plan 6: Verify connect to uphold - Ensured that uphold account can be connected

image

  • Sent a one time tip to verified publisher (3zsistemi.si) from KYC'd uphold account and ensured Tips are processed successfully and transactions are listed in uphold
    image

  • Sent a one time tip to media publisher (Twitter) from KYC'd uphold account and ensured Tips are processed successfully and transactions are listed in uphold
    image
    image

Plan 6.1: Verify creating new uphold account

  • Verified the new KYC'd uphold account creation in 1.18.x

  • Ad grants are not moved to uphold card. Encountered Ad grants do not transfer to Uphold #12966

  • Verified that able to send one-time tip to the media publisher Twitter

  • Verified that Tips are displayed in Tips section and settings summary section

  • Verified that Tips are shown in monthly statement and rewards internal page
    image
    image
    image
    image
    image

  • Verified that transactions are listed in uphold
    image

Verification passed on LG Nexus 5 with Android 5.1 running Bravearm.apk. Specific builds used listed in each scenario below.

Verified test plan from brave/brave-core#6680

Plan 1
  • Tested using 1.18.67 Bravearm.apk
  • Confirmed no "Join Rewards" on panel.
  • Confirmed no "Join Rewards" on chrome://rewards page.
Plan 2

plan2

Plan 3
Tips panel Summary
Tip1 Tip2
Plan 4 (Upgrades)

Tested using 1.18.71 Bravearm.apk

  1. Install 1.17.75. Join Rewards, confirm Ads/AC enabled. Disable Rewards. Upgrade to 1.18.x. Confirm Ads/AC off.
  2. Install 1.17.75. Join Rewards, confirm Ads/AC enabled. View at least 1 ad. Add a couple sites to AC table. Upgrade to 1.18.x. Confirm Ads/AC still on. Confirm Ads and AC panels look as expected on chrome://rewards.
  3. Install 1.17.75. Join Rewards, confirm Ads/AC enabled. Disable AC only. Upgrade to 1.18.x. Confirm Ads are still ON and AC is still OFF. Confirmed able to view ad after upgrade.
  4. Install 1.17.75. Join Rewards, confirm Ads/AC enabled. Disable Ads only. Upgrade to 1.18.x. Confirm Ads are still OFF and AC is still ON. Confirmed able to add sites to AC table after upgrade.
  5. Install 1.17.75. Do not join Rewards. Upgrade to 1.18.x. Confirm Ads/AC off.
  6. Install 1.17.75. Hide Rewards icon. Do not join Rewards. Upgrade to 1.18.x. Confirm Rewards icon still hidden. Confirm Ads/AC off.

Encountered #13166 for experiencing onboarding with upgraded profile in scenario 1, 4, 5, 6.

Plan 5

Unable to check on Android

Plan 6

Confirmed able to connect KYC'd Uphold wallet

Panel Popup
UserWallet1 UserWallet2

Confirmed able to tip KYC'd creator with Uphold wallet

Tips Panel Summary
Screenshot_2020-12-14-13-35-09 Screenshot_2020-12-14-13-35-16

Verification passed on Brave v1.18.72 on Samsung Galaxy Tab S5e (Android 9.0)

Verified test plan from brave/brave-core#6680

Plan 1
  • Confirmed no "Join Rewards" on panel.
  • Confirmed no "Join Rewards" on chrome://rewards page.

Screenshot_20201215-151146_Brave
Screenshot_20201215-151207_Brave

Plan 2 ![Screenshot_20201215-151503_Brave](https://user-images.githubusercontent.com/34715963/102227372-c6e30180-3ee9-11eb-8116-9649ec3fa629.jpg)
Plan 3

Screenshot_20201215-151553_Brave

Plan 4 (Upgrades)
  1. Install 1.17.75. Join Rewards, confirm Ads/AC enabled. Disable Rewards. Upgrade to 1.18.x. Confirm Ads/AC off.
  2. Install 1.17.75. Join Rewards, confirm Ads/AC enabled. View at least 1 ad. Add a couple sites to AC table. Upgrade to 1.18.x. Confirm Ads/AC still on. Confirm Ads and AC panels look as expected on chrome://rewards.
  3. Install 1.17.75. Join Rewards, confirm Ads/AC enabled. Disable AC only. Upgrade to 1.18.x. Confirm Ads are still ON and AC is still OFF. Confirmed able to view ad after upgrade.
  4. Install 1.17.75. Join Rewards, confirm Ads/AC enabled. Disable Ads only. Upgrade to 1.18.x. Confirm Ads are still OFF and AC is still ON. Confirmed able to add sites to AC table after upgrade.
  5. Install 1.17.75. Do not join Rewards. Upgrade to 1.18.x. Confirm Ads/AC off.
  6. Install 1.17.75. Hide Rewards icon. Do not join Rewards. Upgrade to 1.18.x. Confirm Rewards icon still hidden. Confirm Ads/AC off.
Plan 5

Unable to check on Android

Plan 6

Confirmed able to connect KYC'd Uphold wallet

Screenshot_20201215-152150_Brave
Screenshot_20201215-152154_Brave

@LaurenWags LaurenWags mentioned this issue Dec 8, 2020
Closed
@rebron rebron changed the title Remove rewards switch Remove redundant rewards setting to address user confusion Dec 9, 2020
@LaurenWags LaurenWags mentioned this issue Dec 11, 2020
Closed
7 tasks
@LaurenWags LaurenWags mentioned this issue Dec 18, 2020
Closed
@mkarolin mkarolin mentioned this issue Apr 27, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@deeppandya deeppandya

@NejcZdovc NejcZdovc

Labels
feature/rewards OS/Android Fixes related to Android browser functionality OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA Pass - Android Tab QA Pass-Win64 QA/Yes release-notes/include
Projects
None yet
Milestone
1.18.x - Release
Development

Successfully merging a pull request may close this issue.

Remove main switch brave/brave-core
6 participants
@deeppandya @anthonypkeane @NejcZdovc @LaurenWags @btlechowski @GeetaSarvadnya