-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove login flow if in Disconnected state #11528
Comments
Verification PASSED on
Disconnect from rewards using
Disconnect from rewards by removing The above cases are not working for the rewards panel as the flow wasn't removed. Created #11760 . Verification passed on
Verified test plan from the description Disconnected from Brave Verified that Login was not shown when Reconnecting through Disconnected from Uphold Verification passed on
Disconnect from rewards using
Disconnect from rewards by removing Encountered #11760 . |
Description
Follow up to #10936
If in
Disconnected
state, we should not show the login flow per https://bravesoftware.slack.com/archives/CB0KCRCQN/p1598890358003000?thread_ts=1598888189.002000&cid=CB0KCRCQNSteps to Reproduce
Actual result:
See login flow
When retesting should check disconnecting manually (via panel and brave://rewards) and should also check disconnecting from Uphold settings
Expected result:
Should not see login flow per above slack thread
Reproduces how often:
easily
Desktop Brave version:
Android Device details:
Version/Channel Information:
Other Additional Information:
Miscellaneous Information:
cc @NejcZdovc @brave/legacy_qa
Included
OS/Android
tag as Android also has this functionality. Please remove if this will not be applicable to Android.The text was updated successfully, but these errors were encountered: